wip; PR for CI
2025 11 self advertise in separate message #33987
pull 0xB10C wants to merge 2 commits into bitcoin:master from 0xB10C:2025-11-self-advertise-in-separate-message changing 3 files +114 −3-
0xB10C commented at 5:23 PM on December 1, 2025: contributor
-
209c60622a
test: address self-annoucement
Test that a node sends a self-annoucement with its external IP to a peer. The self-annoucmenent can be contained in an addr(v2) message along with multiple other addresses. In these test-cases, it's contained in the response to a GETADDR message along with other addresses.
-
cc4d6c111e
p2p: self-advertise our address in separate msg
TODO
-
DrahtBot commented at 5:23 PM on December 1, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33987.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
LLM Linter (✨ experimental)
Possible typos and grammar issues:
self-annoucement -> self-announcement [misspelling; should be "announcement"]
Contexts: C++ comment "// Send the initial self-annoucement..." and Python comments "# The self-annoucement..." (multiple added lines)self-annoucements -> self-announcements [misspelling; should be "announcements"]
Context: C++ comment "// All later self-annoucements are send together..." (also appears as variable names in code but only the comment is addressed)are send -> are sent [incorrect verb form]
Context: C++ comment "// All later self-annoucements are send together with the other addresses."
<sup>2025-12-01</sup>
- 0xB10C closed this on Dec 1, 2025
-
0xB10C commented at 5:23 PM on December 1, 2025: contributor
should have been against my fork... https://github.com/0xB10C/bitcoin/pull/13
