test: fix test_limit_enforcement_package #34001

1. 
   instagibbs commented at 6:00 pm on December 3, 2025: member

   The current test has a couple issues:

   1. the parent_tx_good is regenerating the exact same transaction that is already in the cluster, so it’s resulting in no replacements on submission
   2. once fixed, the additional fee needs to be allocated to the parent transaction in the package, not the child. If the RBF fees are allocated to the child, this triggers the package RBF logic, which requires no in-mempool ancestors to be present.

   Fix the bug and add a few assertions to protect against regressions.

2. test: fix test_limit_enforcement_package

   The current test has a couple issues:
   
   1) the parent_tx_good is regenerating the exact same
   transaction that is already in the cluster, so it's
   resulting in no replacements on submission
   2) once fixed, the additional fee needs to be allocated to
   the parent transaction in the package, not the child. If the
   RBF fees are allocated to the child, this triggers the
   package RBF logic, which requires no in-mempool ancestors to
   be present.
   
   Fix the bug and add a few assertions to protect against
   regressions.

   0a8d303d66
3. DrahtBot added the label Tests on Dec 3, 2025
4. 
   DrahtBot commented at 6:00 pm on December 3, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34001.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   LLM Linter (✨ experimental)

   Possible typos and grammar issues:

   • its meant -> it’s meant [missing apostrophe; “its” (possessive) should be “it’s” (it is) to mean “as it is meant to replace”]

   2025-12-03

5. 
   instagibbs commented at 6:03 pm on December 3, 2025: member

   cc @sdaftuar @glozow
6. fanquake added this to the milestone 31.0 on Dec 17, 2025

Contributors
instagibbs DrahtBot

Labels
Tests

Milestone
31.0