LevelDB 1.15

sipa commented at 9:11 pm on December 12, 2013: member

This updates the src/leveldb subtree to LevelDB 1.15 (+ our patches).

The tree is pulled from the bitcoin/leveldb repository, branch bitcoin-fork.

fix wrong memcmp() usage in CKey::operator==

- add a check for CKey::size() of a and b (size can be 0 or 32)
- change the fixed value in memcmp() to use a.size() instead
- fixes #3090

a39967401e

Bug fix: CDataStream::GetAndClear() when nReadPos > 0

Changed CDataStream::GetAndClear() to use the most obvious
get get and clear instead of a tricky swap().

Added a unit test for CDataStream insert/erase/GetAndClear.

Note: GetAndClear() is not performance critical, it is used only
by the send-a-message-to-the-network code. Bug was not noticed
before now because the send-a-message code never erased from the
stream.

d5d1425657

-fuzzmessagestest=N : randomly corrupt 1-of-N sent messages

I needed this to test the new "reject" p2p message, but it should be generally
useful for fuzz-testing network message handling code.

9038b18f46

Merge pull request #3162 from sipa/saninsert

Remove redundant insert method in serialize

cde10602a6

Merge pull request #3115 from sipa/walletmain

Interaction cleanups between main and wallet

e13934c94e

Merge pull request #3173 from gavinandresen/fuzzmessages

-fuzzmessagestest=N : randomly corrupt 1-of-N sent messages

951ed190fb

Merge pull request #3176 from Diapolo/key

fix wrong memcmp() usage in CKey::operator==

42a12f22d6

re-work -debug switch handling

- re-work -debug help message text
- make -debug log every debugging information again (even all categories)
- remove unneeded fDebug checks in front of LogPrint()/qDebug(), as that
  check is done in LogPrintf() when category is != NULL (true for all
  LogPrint() calls
- remove fDebug ONLY in code which is NOT performance-critical
- harmonize addrman category name
- deprecate -debugnet usage, should be used via -debug=net and remove the
  corresponding global

3b570559f8

Merge pull request #3160 from Diapolo/walletview

[Qt] walletview: make backupWallet() use GUIUtil::getSaveFileName()

033ffc4377

transactionview: add message() signal

- allow to use message() in transactionview by connecting to the
  message() signal in WalletView

868d3ee5ac

transactionview: make exportClicked() use message()

- use message() for displaying success or failure of export
- rework the strings to be more detailed / informative
- additional small cleanups

9eb4ab66bf

[Qt] sendcoinsdialog: convert QMessageBox usage to message()

- add new processSendCoinsReturn() function, which parses the
  status of WalletModel::SendCoinsReturn and generates a pair consisting
  of a message and message flags
- result is we only need one emit message() call
- this change ensures that the GUI is shown for warnings/errors in
  sendcoinsdialog, because of message() taking care of that for modal
  messages
- changes 2 warning message into error messages and removed "Error:"
  in front of the actual error message string

71ba4670fc

Merge pull request #3067 from Diapolo/debug-switch

re-work -debug switch handling

ef4b518aea

Merge pull request #3189

71ba467 [Qt] sendcoinsdialog: convert QMessageBox usage to message() (Philip Kaufmann)

cd6426ec72

Merge pull request #3159

9eb4ab6 transactionview: make exportClicked() use message() (Philip Kaufmann)
868d3ee transactionview: add message() signal (Philip Kaufmann)

ede3ee3348

[Qt] Rework of payment request UI (mainly for insecure pr)

- this shows insecure (unsecured) payment requests in a new yellowish
  colored UI (based on the secure payment request UI) instead of our
  normal payment UI
- allows us to receive paymentACK messages for insecure payment requests
- allows us to handle expirations for insecure payment request
- changed walletmodel, so that all types of payment requests don't touch
  the addressbook

c6c97e0f4e

payment-request UI: use SendCoinsRecipient.message for memo 983cef4802

make processPaymentRequest() use a single SendCoinsRecipient

- as one this pulls main purpose is to change a payment request to
  be displayed as a single sendcoins entry

952d2cdb56

rework an ugly hack in processPaymentRequest()

- use a QStringList to store valid addresses and format them for GUI and
  debug.log usage via .join()

395d0d5af0

Do not use the redundant BestInvalidWork record in the block database.

As block index entries have a flag for marking invalid blocks, the
'best invalid work' information can be derived from there. In addition,
remove the global from main.h

85eb2cef33

Make some globals in main non-public.

This means they are declared static, and their extern definition in
main.h is removed. Also moved CBlockIndexWorkComparator to the .cpp
file.

caca6aa4eb

Merge pull request #3114

a616206 Give peer time-adjustment data an own lock (Pieter Wuille)

1dffbf0060

Merge pull request #3128

0056095 Show short scriptPubKeys correctly (Peter Todd)
22de68d Relay OP_RETURN TxOut as standard transaction type (Peter Todd)

Signed-off-by: Gavin Andresen <gavinandresen@gmail.com>

837369806a

Check integrity of gitian input source tarballs b31482844b

Merge pull request #3087

caca6aa Make some globals in main non-public. (Pieter Wuille)
85eb2ce Do not use the redundant BestInvalidWork record in the block database. (Pieter Wuille)

694c7c8161

.gitignore: Simplify references to the same file in different directories

Unless a .gitignore pattern is anchored, it'll match in any directory, not juts at the top level.  Simplify .gitignore accordingly.

edd6c8f94f

make -logtimestamps default on and rework help-message 959e62f0c8

Merge pull request #3193 from joshtriplett/patch-1

.gitignore: Simplify references to the same file in different directories

39b4f0d7dd

Refactor: CTxMempool class to its own txmempool.{cpp,h} 319b11607f

Merge pull request #3154 from gavinandresen/mempool_refactor

Mempool refactor

a95a1c06b1

process received messages one at a time without sleeping between messages 75ef87dd93

Skip comparison tool on win32 since Wine breaks it 338d24bb00

Merge pull request #3180 from pstratem/processgetdata

Reduce latency in network processing

97f844dd95

No more fHaveGUI

No more specific handling of GUI in bitcoin core.
Replace the last usage of fHaveGUI with a fForceServer
parameter on AppInit2.

e30bd78f81

Merge pull request #3076 from lano1106/uint256_util

Make util phexdigit array reusable

bac72640ee

Merge pull request #3188 from Diapolo/logtimestamp_def

make -logtimestamps default on and rework help-message

c4f2a002ca

qt: add license header to source files

Closes #839

e592d43f51

Make time facet non-constant e5a2c9794c

Merge pull request #3197 from laanwj/2013_11_qt_license

qt: add license header to source files

e304dbd3f8

Merge pull request #3198 from nvmd/compile_on_mavericks

Make time facet non-constant

63bea1d2e6

Merge pull request #3196 from laanwj/2013_11_nohavegui

No more fHaveGUI

25d056a58f

qt: remove unused signal from addresstablemodel c82cddcc55

[Qt] use tr() instead of QObject::tr() in intro.cpp 011e1c060a

[Qt] remove unused optionsmodel from addressbookpage 5cd85c4228

Merge pull request #3205 from Diapolo/intro

[Qt] use tr() instead of QObject::tr() in intro.cpp

07131220f3

Merge pull request #3206 from Diapolo/addressbookpage_model

[Qt] remove unused optionsmodel from addressbookpage

04f5286096

[Qt] make event() and eventFilter() in askpassphrasedialog protected a80b1a0312

Merge pull request #3145

395d0d5 rework an ugly hack in processPaymentRequest() (Philip Kaufmann)
952d2cd make processPaymentRequest() use a single SendCoinsRecipient (Philip Kaufmann)
983cef4 payment-request UI: use SendCoinsRecipient.message for memo (Philip Kaufmann)
c6c97e0 [Qt] Rework of payment request UI (mainly for insecure pr) (Philip Kaufmann)

65d0fc4b73

Merge pull request #3191 from wtogami/integrity_check

Check integrity of gitian input source tarballs

182e9090a5

Merge pull request #3209

a80b1a0 [Qt] make event() and eventFilter() in askpassphrasedialog protected (Philip Kaufmann)

b744fdbf52

[Qt] rename rpcconsole window

- rework window title to not include Bitcoin - in front, as no other
  dialog does this
- favor a connect() call over an own function for clearing the traffic
  graph
- write monospace lowercase (seems to be correct after some web search)
  and add a comment that we should avoid / remove fixed font sizes

91163c15f6

Merge pull request #3222 from Diapolo/debug-window

[Qt] rename rpcconsole window

7f0ccea768

Merge pull request #3155 from wtogami/split_proto_var

Split MIN_PROTO_VERSION into INIT_PROTO_VERSION and MIN_PEER_PROTO_VERSION

9a165e5714

Add a few more basic script/tx test-cases. eacc6f4a26

Merge pull request #3223 from TheBlueMatt/master

Test changes

995cb284cf

Rename leveldb.{h,cpp} to leveldbwrapper.{h,cpp}. b64187d05f

Merge pull request #3211

b64187d Rename leveldb.{h,cpp} to leveldbwrapper.{h,cpp}. (Brandon Dahler)

7c4c207be8

Cleanup code using forward declarations.

Use misc methods of avoiding unnecesary header includes.
Replace int typedefs with int##_t from stdint.h.
Replace PRI64[xdu] with PRI[xdu]64 from inttypes.h.
Normalize QT_VERSION ifs where possible.
Resolve some indirect dependencies as direct ones.
Remove extern declarations from .cpp files.

51ed9ec971

Merge pull request #2767

51ed9ec Cleanup code using forward declarations. (Brandon Dahler)

f76c122e2e

Make CCoinsView use block hashes instead of indices 84674082b0

Move CCoins-related logic to coins.{cpp.h} a0fa20a12b

Fix struct/class declaration mismatches 3a6faabecf

Improve logging of failed connections 0f90613cbe

Refactor: pull alert string sanitization into util 17faf56262

New reject p2p message 358ce2664d

Test alerts high at high PROTOCOL_VERSIONs

I regenerated the alert test data; now alerts are tested
against a protocol version way above the current protocol
version.

So we won't have to regenerate them every time we bump
PROTOCOL_VERSION in the future.

feaec80cb0

Bump protocol version to 70002 69aada346f

Merge pull request #3185 from gavinandresen/reject

Reject p2p message

16d5f2c5e0

Merge pull request #3199 from sipa/mempoolmove

Cleanup refactoring of coins/mempool

7d7df381f8

Update build docs that refer to old makefile.* files.

Also update pull-tester's error message.

2b91707469

doc: add note about building on Ubuntu 13.10

Also mention `autoconf` as required package.

7a6fed86d3

Merge pull request #3232 from laanwj/2013_11_ubuntu1310

doc: add note about building on Ubuntu 13.10

fb4a31a26c

configure: Simplify common AM_CPPFLAGS and AM_LDFLAGS to a Makefile.common eb12a14da7

Merge pull request #3231 from brandondahler/doc-autotool-update

Update build docs that refer to old makefile.* files.

59be91ae1e

configure: Automatically disable bitcoin-qt by default, if dependencies are not met fcfbf547d3

Merge pull request #3233 from laanwj/2013_11_autoconf

Autoconf improvements

bb8f9179ad

doc: replace DOS with MSYS shell to be more consistent

A plain DOS window doesn't have the right path settings, whereas
the MSYS shell window does.

3a8915d9a8

[Qt] paymentserver: start netManager in uiReady()

- remove explicit init of netManager as this is done in the constructor
  anyway
- move initNetManager() call to uiReady(), which removes an assert() and
  allows us to use message() in initNetManager() (currently unused but
  could be necessary because of proxy related messages)
- make initNetManager() private
- update paymentservertests.cpp

7634e0d8de

Space saving in /doc README.

Fixed. Split off build, and bootstrap link.

a11dd1e67c

qt: add Open URI dialog 4c60358604

Merge pull request #3215 from laanwj/2013_11_openuridialog

qt: add Open URI dialog

c2468c1542

Merge pull request #3138 from super3/master

Squash README

2b8c4410c1

Merge pull request #3187 from Diapolo/netManager

[Qt] paymentserver: start netManager in uiReady()

a6aa179699

misc small changes to polish after include cleanup cd696e64df

[Qt] remove GUIUtil::getSaveFileName() default arguments

- harmonize function with GUIUtil::getOpenFileName()
- also make PNG Image singular (grammar)

4f7d496b82

Merge pull request #2980 from wtogami/silenceunusedwarning

Silence useless warning in src/json/json_spirit_writer_template.h to mak...

07866e3cd6

Merge pull request #3235 from Diapolo/misc

misc small changes to polish after include cleanup

309f783fce

Merge pull request #3238 from Diapolo/guiutil

[Qt] remove GUIUtil::getSaveFileName() default arguments

abf34606c0

init.cpp: cosmetic indent changes, preparing for no-wallet mode f9ee7a032b

qt: make URI scheme comparison case insensitive

Fixes ancient issue #1460.

b3e579713f

Merge pull request #3241 from laanwj/2013_11_uri_scheme_case_insensitive

qt: make URI scheme comparison case insensitive

d6c434d97e

Add -disablewallet option, to disable wallet support (and BDB) e6b7e3dc79

qt: GUI support for -disablewallet mode 146ba964e4

Merge pull request #3240 from laanwj/2013_11_rebase_no_wallet

Introduce disable-wallet / no-wallet mode (rebased)

2830a9051d

Issue #1865 - Clean up RPC help messages

Based on the proposal, update the help message of rpc methods
- strings arguments are in double quotes rather than square brackets
- numeric arguments have no quotes (and no default value)
- optional parameters are surrounded by round brackets
- json arguments are strings but don't use double quotes

Added 3 sections for the details
- Arguments: lists each argument, it's type, required or not, a default, and a description
- Result: The method result, with json format if applicable, type, and a description
- Examples: examples calls using bitcoin-cli and curl for json rpc call

Problems
- maybe this is too verbose
- lines might be too long
- description are not good or complete
- examples may be too much

a6099ef319

Use C99 printf statements in mingw

Otherwise, format specifiers such as %llu will not work on XP or
earlier.
This bug was introduced with 51ed9ec9.
http://sourceforge.net/apps/trac/mingw-w64/wiki/gnu%20printf

d6f690f7da

tests: add testcases for strprintf c82788efff

Merge pull request #3246 from laanwj/2013_11_rpc_help

Clean up RPC help messages (rebased)

194aa6cfdf

Merge pull request #3244 from laanwj/2013_11_mingw_c99_printf

Use C99 printf statements in mingw

5ce4361077

configure: lupdate is not needed for Qt build

Don't require lupdate to build with Qt. Like xgettext it is only
needed to update translations, not for normal builds.

This fixes the gitian build (broken by fcfbf547d).

6ad44f5693

qt: align amounts on overview page to the right

This is more consistent with other places in the GUI.

79afdd1869

pass nBytes as parameter to GetMinFee(..) 8dfd8c62dc

Coin Control Features 6a86c24db1

qt: language update from transifex

Adds three new languages:

- de_AT: German (Austria)
- gl: Galician
- sl_SI: Slovenian (Slovenia)

Updates many others.

Thanks to the translators contributing on Transifex!

22d1ac44dc

[Qt] make most Windows appear centered on main GUI

- remove default value for parent variable in dialogs, which should appear
  centered over main GUI and pass appropriate value
- add some addition NULL pointer checks

309f796b39

Merge pull request #3248 from laanwj/2013_11_overviewpage_align

qt: align amounts on overview page to the right

04744b8b54

Merge pull request #3252 from laanwj/2013_11_transifex_pull

qt: language update from transifex

4fc241235c

core: remove includes in .cpp, if header is already in .h

- example: if util.h includes stdint.h, remove it from util.cpp, as
  util.h is the first header included in util.cpp

379778bde6

orphan spaces cleanup ;-) fabba0e6cc

Merge pull request #3258

fabba0e orphan spaces cleanup ;-) (Philip Kaufmann)

5082b50a65

Remove Wallet Tools

We already have the exact same funtionality in /contrib/bitrpc/bitrpc.py

If we really do need standalone scripts, then I'll write something to
pull it from that file, rather than having duplicate code.

Forgot to remove wallet tools from index.

Wallet Tools Follow Up Info

43bba5d012

Merge pull request #3255

309f796 [Qt] make most Windows appear centered on main GUI (Philip Kaufmann)

0b4bd485ba

Merge pull request #3253

6a86c24 Coin Control Features (Cozz Lovan)
8dfd8c6 pass nBytes as parameter to GetMinFee(..) (Cozz Lovan)

3443adecf1

[Qt] use GUIUtil::setClipboard() where possible 79fac3f427

Merge pull request #3268

79fac3f [Qt] use GUIUtil::setClipboard() where possible (Philip Kaufmann)

af6e093f06

doc: small doxygen update

I was merging change this every time before generation of
the doxygen developer docs (https://dev.visucore.com/bitcoin/doxygen/)
but there's no reason why it can't just be merged upstream.

0e165b97d9

qt: show all units in send confirmation

Make users accustomed to the other subdivision units (mBTC, muBTC)
by showing the total amount in all units in the confirmation dialog.

This was recently raised on the mailing list and could be a preparation
for switching over the default unit eventually.

fb0507fe4b

Add additional data update to release-process.md

This adds https://github.com/bitcoin/bitcoin.org/pull/270 to the to-do
list for each release, avoiding future situations like
https://bitcointalk.org/index.php?topic=336042.0.

cc3b0dddbc

Coincontrol cleanup (e.g. add missing license)

- add missing license headers
- make compatible with Qt5
- enforce header cleanup style
- small code style cleanups
- rename Coin Control dialog into Coin Control Address Selection
- use default font for the windows labels (no monospace)

0689f46cc7

Merge pull request #3272

0e165b9 doc: small doxygen update (Wladimir J. van der Laan)

8808435814

Merge pull request #3275 from Michagogo/release-process-binary-sizes

Add additional data update to release-process.md

5235db2c1e

Merge pull request #3267

0689f46 Coincontrol cleanup (e.g. add missing license) (Philip Kaufmann)

71f97ea2a7

Update ax_boost_base.m4 to serial 21

- Add aarch64 to the list of lib64 architectures

3f064488e9

Update ax_boost_filesystem.m4 to serial 26

- Fixed cut-and-paste error.
- See http://savannah.gnu.org/patch/?7576 for further details.
- Use 'ls -r' rather than non-portable tool 'tac'.
- Simplify filepattern in ls expression so dylib (on OSX) are also detected.

41276b4695

Update ax_boost_program_options.m4 serial 22

- Fixed detection of dynamic libraries on Mac OS X (*.dylib)

See http://savannah.gnu.org/patch/?7719 for further details.

2fb65108f3

Update ax_boost_system.m4 to serial 17

- Use 'ls -r' rather than non-portable tool 'tac'. Simplify filepattern in ls expression so dylib (on OSX) are also detected.

f9374cafa5

Update ax_boost_thread.m4 to serial 27

- Use 'ls -r' in order to try newer version before older ones. Simplify
  ls pattern so also dylibs are detected.

e4235c38ff

Update ax_pthread.m4 to serial 21

- Add support for Clang

Further details can be found at http://savannah.gnu.org/patch/?8186

ea89d521d6

Merge pull request #3278 from laanwj/2013_11_boost_m4

Update boost m4 files

993a50b683

qt: keep a list of requested payments

Keep a list of requested payments in the Receive tab so that a user can
recall previously created requests after closing their windows.

Currently this list is not stored between bitcoin-qt sessions. This can
be implemented later, but it is not clear where it should be stored as
I don't think it belongs in the wallet (maybe in QSettings?)

666893b1fa

Merge pull request #3234 from super3/master

Remove Wallet Tools

96aaf006a5

RPC client option: -rpcwait, to wait for server start 480e75ceab

[Qt] make a UI element in sendcoins non-validated

- this was unused for the label and also makes no sense, so remove it

67448b245c

Merge pull request #3257

379778b core: remove includes in .cpp, if header is already in .h (Philip Kaufmann)

d980f9b7d6

Provide build time when building from tarball:

 When building from tarball (i.g. not from git source tree or when git
 is not available) `genbuild.sh` write undefined $TIME to "build/build.h".

 Even worse, when TIME is set in the environment then its value
 is written instead of a date.

 For me this change fixed FTBFS which I got because I had
 TIME enviroment variable set with format for time(1) utility.

ef1e984ead

Merge pull request #3283 from gavinandresen/rpcwait

RPC client option: -rpcwait, to wait for server start

34f5b0ab93

Merge pull request #3293 from onlyjob/master

Provide build time when building from tarball:

f7e88c39d7

Merge pull request #3287

67448b2 [Qt] make a UI element in sendcoins non-validated (Philip Kaufmann)

35454b35d8

setgenerate creates multiple blocks in -regtest mode

I'm writing some wallet regression tests using -regtest mode, and
need to generate an initial multi-hundred-block chain. Repeatedly
calling setgenerate to generate one block is slow and doesn't
work properly, because block creation happens asynchronously.

This adds two features to setgenerate in -regtest mode:

1) Instead of being interpreted as number of threads to start, the
third argument is the number of blocks to generate.

2) setgenerate will not return until the block creation threads
have created the requested number of blocks.

c8b74258ba

Remove '/': prefix always starts with '/'

brew --prefix retruns a fully qualified path, so using -L/$prefix results in a path with two leading '/'.

c89d59c38a

cleanup error message consistency

relicts from the CTransaction refactor.

848fe68acd

Merge pull request #3299

c89d59c Remove '/': prefix always starts with '/' (Florin)

76cfa60222

Merge pull request #3273

fb0507f qt: show all units in send confirmation (Wladimir J. van der Laan)

be5d37c597

Move types.h include before ifaddres.h for u_int declaration 9ac5a01c73

Merge pull request #3300

848fe68 cleanup error message consistency (Julian Langschaedel)

eef8a67abf

contrib: add sipa's github-merge script e5adec35c6

Merge pull request #3302

e5adec3 contrib: add sipa's github-merge script (Wladimir J. van der Laan)

d4cda964d2

[Qt] allow deletion of payment-requests in sendcoins

- this adds a delete button for insecure and secure payment requests in
  the sendcoins dialog
- it also enables the delete button even for single and empty entries, as
  this is much easier to handle and doesn't need to special case single
  entries
- big parts of the ui file were changed, because I copied the delete
  button and had to delete the layout too and created it from scratch
  (which seems to cleanup the rows and colums in the layout also, which is
  nice IMHO)

84b695cc9d

Merge pull request #3294

c8b7425 setgenerate creates multiple blocks in -regtest mode (Gavin Andresen)

4c3e24644d

Fix uninitialized variable added in b33b9a6fe

After discussing with BlueMatt, this appears to be harmless in its
current state since it's always set before it's used. Initialize it
anyway for readability and future safety.

106f133de6

Merge pull request #3316

106f133 Fix uninitialized variable added in b33b9a6fe (theuni)

03b6a1cee4

Add some additional logging to give extra network insight. ba6a4ea344

Store and use a sanitized subVer a946aa8d3e

qt: restore icon dock menu

This was removed by 25c0cce7f. It was apparently removed in qt5, but
may return for 5.1.

871ac375bd

Integration tests via RPC calls

qa/rpc-tests/wallet.sh runs a three-node -regtest network,
generates a fresh blockchain, and then exercises basic wallet
sending/receiving functionality using command-line RPC.

9e7776bf1f

Split up bitcoinrpc (code movement only)

Split bitcoinrpc up into

- rpcserver: bitcoind RPC server
- rpcclient: bitcoin-cli RPC client
- rpcprotocol: shared common HTTP/JSON-RPC protocol code

One step towards making bitcoin-cli independent from the rest
of the code, and thus a smaller executable that doesn't have to
be linked against leveldb.

This commit only does code movement, there are no functional changes.

fb78cc2378

Merge pull request #3319

871ac37 qt: restore icon dock menu (theuni)

2fc12794c2

Merge pull request #3296

a946aa8 Store and use a sanitized subVer (Mike Hearn)
ba6a4ea Add some additional logging to give extra network insight. (Mike Hearn)

e1169d7eea

Merge pull request #3284

fb78cc2 Split up bitcoinrpc (code movement only) (Wladimir J. van der Laan)

5f083afde1

prevent Windows redefinition warning cause by compat.h 0078841617

autogen.sh: Add a /bin/sh shebang. f80b723c66

autogen.sh: Use set -e to fail if any command fails

In preparation for expanding autogen.sh.

97d285ab51

autogen.sh: Support running from outside the source directory

Initial steps towards supporting out-of-tree builds.

19b9adda52

autogen.sh: Use long options to autoreconf, for self-documentation e12dafd7bb

autogen.sh: Stop passing --verbose to autoreconf

This quiets down the autotools build, making warnings much more visible.

82ccb05b07

configure.ac: Check for miniupnpc headers, not just -lminiupnpc

This protects against broken systems which have libminiupnpc.a or
libminiupnpc.so installed but don't have the miniupnpc headers.

a26a367629

src/Makefile.am: Simplify clean of leveldb 26d1b65c53

Merge pull request #3321

0078841 prevent Windows redefinition warning cause by compat.h (Philip Kaufmann)

4ae42d43a4

bitcoin-cli: Add missing SelectParamsFromCommandLine

The SelectParamsFromCommandLine call was missing in bitcoin-cli,
which caused `-testnet` and `-regtest` to be ignored. Add this
call just like in bitcoind.cpp.

9d2b73d19f

Merge pull request #3295

9e7776b Integration tests via RPC calls (Gavin Andresen)

207cfbfbf1

Merge pull request #3328

9d2b73d bitcoin-cli: Add missing SelectParamsFromCommandLine (Wladimir J. van der Laan)

5c56ee1ace

mutex debugging routines: LocksHeld() and AssertLockHeld() c649637b6c

Merge pull request #3309

9ac5a01 Move types.h include before ifaddres.h for u_int declaration (Robert Backhaus)

e7e8a7537a

Remove dead transaction replacement code

This dead code can be resurrected from git history if
transaction replacement is ever implemented. Keeping
dead code in the source is a bad idea, because it implies
it was tested and worked at some point, which is not true.

98c7c8fd1d

Refactor: move GetValueIn(tx) to tx.GetValueIn()

GetValueIn makes more sense as a CTransaction member.

0733c1bde6

Add verbose boolean to getrawmempool

Also changes mempool to store CTxMemPoolEntries
to keep track of when they enter/exit the pool.

4d707d5120

Merge pull request #3239 from gavinandresen/mempool_verbose

Add verbose flag to getrawmempool

b78d1cdf82

Merge pull request #3306

84b695c [Qt] allow deletion of payment-requests in sendcoins (Philip Kaufmann)

40ad6e7f35

Merge pull request #3329 from gavinandresen/syncdebug

mutex debugging routines: LocksHeld() and AssertLockHeld()

a65edb104d

Make unit tests succeed with -DDEBUG_LOCKORDER 49dc3a0f1a

Fix a rare crash on Mac OS X, by removing a setFocus on the payTo field that was not necessary, as the field still receives focus without it. bae6c7e32b

Merge pull request #3339

bae6c7e Fix a rare crash on Mac OS X, by removing a setFocus on the payTo field that was not necessary, as the field still receives focus without it. (Ryan Niebur)

b9988c9e74

Lossless image optimization

less bytes, same images

d6cb85d50d

Merge pull request #3341 from Need4Video/master

Lossless image optimization

9ab7a0609e

[Qt] coin-control features GUI cleanup 2

- remove monospace labels from sendcoinsdialog also
- use a validated line edit for the change address
- add a tooltip to change address switch
- ensure we have a valid change address in
  CoinControlDialog::coinControl->destChange or just CNoDestination()
- some small ui file changes

834e14e57f

[Qt] coin-control features GUI cleanup 3

- remove style sheets from ui files and use Qt attributes instead
- make some more strings untranslatable, to make life for translators
  easier
- split up long tooltips an rework the texts a little

d3207b6fa8

Sanitize assert usage and refuse to compile with NDEBUG.

There were quite a few places where assert() was used with side effects,
 making operation with NDEBUG non-functional.  This commit fixes all the
 cases I know about, but also adds an  #error on NDEBUG because the code
 is untested without assertions and may still have vulnerabilities if
 used without assert.

9b59e3bda8

Fix file hash verification error in deps-win32.yml

libpng was being sha256summed twice, and miniupnpc wasn't being checked at all.

c51e49b1a3

Merge pull request #3344 from gmaxwell/assert_hazards

Sanitize assert usage and refuse to compile with NDEBUG.

2aed2b30b1

Merge pull request #3345 from Michagogo/gitian-descriptor-deps-input-typo

Fix file hash verification error in deps-win32.yml

0563ee952c

bitcoin-cli: remove unneeded dependencies (only code movement)

Remove unnecessary dependencies for bitcoin-cli
(leveldb, berkelydb, wallet, RPC server)

Build system changes:
- split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and
  libbitcoin_cli.a

Code changes (movement only):
- split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli
  in rpcclient.cpp
- move uiInterface from init.cpp to util.cpp

0b47fe6bdc

Merge pull request #3320 from laanwj/2013_11_cli_split

bitcoin-cli: remove unneeded dependencies (only minor code movement)

cf74e8cb5e

[Qt] small notificator and style changes

- remove default arguments for notificator
- re-order some calls to use same ordering in Qt files
- style police changes (spaces, comments and such)

ccd1372dd0

Merge pull request #3285

d3207b6 [Qt] coin-control features GUI cleanup 3 (Philip Kaufmann)
834e14e [Qt] coin-control features GUI cleanup 2 (Philip Kaufmann)

f15bd3c96f

Payment request URI syntax changed, from request=... to r=...

BIP 72 was changed to save six bytes in bitcoin: URIs.

1e01f7c506

qt: use deleteLater to remove send entries

Use deleteLater() instead of delete, as it is not allowed
to delete widgets directly in an event handler.
Should solve the MacOSX random crashes on send with coincontrol.

6c98cca9e4

Merge pull request #3355

6c98cca qt: use deleteLater to remove send entries (Wladimir J. van der Laan)

00cfc9f074

Move HelpExample* from rpcwallet to rpcserver

General functions used throughout the RPC framework
don't belong in rpcwallet.

bbb093652e

Move getinfo to rpcnet.cpp

Where to place `getinfo` is a difficult issue
as it shows information from the wallet, net and
block chain. However, I moved it out of rpcwallet
as the command needs also to be available without
wallet.

991685d3dc

Delimit code with #ifdef ENABLE_WALLET

Delimit all code that uses the wallet functions
in implementation files that conditionally use the wallet.

48ba56cdfd

Move CAddrDB frrom db to net

This was a leftover from the times in which
peers.dat depended in BDB.

Other functions in db.cpp still depend on BerkelyDB,
to be able to compile without BDB this (small)
functionality needs to be moved to another file.

d004d7279f

Add --disable-wallet option to build system

Make it possible to build Bitcoin without wallet
(and thus without BDB) so that it only functions as node.

4f9e993bc9

Update build-unix.md to mention --disable-wallet

Mention the new --disable-wallet mode.
Also, correct the BDB entry in the dependencies table.

ae6ea5a6fa

Move CCryptoKeyStore to crypter.cpp

This breaks the dependency on crypter for disable-wallet builds.

829c920387

Split off rpc_wallet_tests

Split wallet tests from other RPC tests.
Now no #ifdef ENABLE_WALLET are needed anymore in either file.

5094f8d46f

Prevent empty transactions from being added to vtxPrev

CWalletTx::AddSupportingTransactions() was adding empty transaction
to vtxPrev in some cases. Skip over these.

Part one of the solution to #3190. This prevents invalid vtxPrev from
entering the wallet, but not current ones being transmitted.

d3ef9b00ec

Refuse to retransmit transactions without vins

Versions of bitcoin before 0.8.6 have a bug that inserted
empty transactions into the vtxPrev in the wallet, which will cause the node to be
banned when retransmitted, hence add a check for !tx.vin.empty()
before RelayTransaction.

4ef92a9067

Merge pull request #3357

4ef92a9 Refuse to retransmit transactions without vins (Wladimir J. van der Laan)

80ca273b7f

Merge pull request #3356

d3ef9b0 Prevent empty transactions from being added to vtxPrev (Wladimir J. van der Laan)

b1961523f1

fix typo in rpcnet.cpp 38cbeab1ff

Merge pull request #3359

38cbeab fix typo in rpcnet.cpp (Philip Kaufmann)

ac57a2320f

Change release-process.md to sign release tags cc75306ceb

Merge pull request #3362 from Michagogo/signed-tags

Change release-process.md to sign release tags

d6d12f932d

Merge pull request #3353

1e01f7c Payment request URI syntax changed, from request=... to r=... (Gavin Andresen)

b4297c8fff

[Qt] misc PaymentServer changes (e.g. changes to eventFilter())

- make eventFilter() private and pass events on to QObject::eventFilter()
  instead of just returning false
- re-work paymentservertest.cpp to correctly handle the event test
  after the above change (rewrite test_main to allow usage of
  QCoreApplication:: in the tests)
- delete socket when we were unable to connect in ipcSendCommandLine()
- show a message to the user if we fail to start-up (instead of just a
  debug.log entry)
- misc small comment changes

4cf3411056

Merge pull request #3254

4cf3411 [Qt] misc PaymentServer changes (e.g. changes to eventFilter()) (Philip Kaufmann)

9ac11a4e1e

Restore hex to getrawtransaction vout scriptPubkey.

Commit be066fad accidentally removed the hex field.
This gets in the way of doing offline signing.

(credit belongs to sipa for actually looking for the
 cause instead of being lazy like me and just shrugging
 and writing the scriptpubkey from the asm.)

a702a0b61d

Merge pull request #3365 from gmaxwell/hexify

Restore hex to getrawtransaction vout scriptPubkey.

fbbed19b78

Merge pull request #3332

5094f8d Split off rpc_wallet_tests (Wladimir J. van der Laan)
829c920 Move CCryptoKeyStore to crypter.cpp (Wladimir J. van der Laan)
ae6ea5a Update build-unix.md to mention --disable-wallet (Wladimir J. van der Laan)
4f9e993 Add --disable-wallet option to build system (Wladimir J. van der Laan)
d004d72 Move CAddrDB frrom db to net (Wladimir J. van der Laan)
48ba56c Delimit code with #ifdef ENABLE_WALLET (Wladimir J. van der Laan)
991685d Move getinfo to rpcnet.cpp (Wladimir J. van der Laan)
bbb0936 Move HelpExample* from rpcwallet to rpcserver (Wladimir J. van der Laan)

05e27c6641

Merge pull request #3322

26d1b65 src/Makefile.am: Simplify clean of leveldb (Josh Triplett)
a26a367 configure.ac: Check for miniupnpc headers, not just -lminiupnpc (Josh Triplett)
82ccb05 autogen.sh: Stop passing --verbose to autoreconf (Josh Triplett)
e12dafd autogen.sh: Use long options to autoreconf, for self-documentation (Josh Triplett)
19b9add autogen.sh: Support running from outside the source directory (Josh Triplett)
97d285a autogen.sh: Use set -e to fail if any command fails (Josh Triplett)
f80b723 autogen.sh: Add a /bin/sh shebang. (Josh Triplett)

6893d74e15

Merge pull request #3348

ccd1372 [Qt] small notificator and style changes (Philip Kaufmann)

70370ae502

Add main-specific node state b2864d2fb3

Add ThreadGetMyExternalIP to net thread group

Fixes #3372 -- crash at shutdown.

80ecf6702a

Merge pull request #3276 from sipa/nodestate

Add main-specific node state & move ban score

7202d9d9bf

Allow mining RPCs with --disable-wallet

The following mining-related RPC calls don't use the wallet:

- getnetworkhashps
- getmininginfo
- getblocktemplate
- submitblock

Enable them when compiling with --disable-wallet.

4a85e06750

Move internal miner functionality together acfa03337e

Re-enable miner tests in --disable-wallet mode

Use a fixed script instead of a CReserveKey from the wallet.
This does not affect the functionality or result of the tests as they never
check the state of the wallet in the first place.

fbc7a96d03

some string and indentation updates in init/rpcclient b6aafca03d

Merge pull request #3373

80ecf67 Add ThreadGetMyExternalIP to net thread group (Gavin Andresen)

7266bb1bdc

cleanup includes in rpcnet.cpp fdbdb7f345

[Qt] misc small Mac related changes/cleanups

- cleanup Info.plist.in and specify high DPI mode enable command as per
  http://blog.qt.digia.com/blog/2013/04/25/retina-display-support-for-mac-os-ios-and-x11/
- move setting of QApplication::setAttribute() to bitcoin.cpp and add
  attribute for enabling use of high DPI pixmaps for Qt >= 5.1
- add missing setWindowTitle() on Mac
- cleanup Mac / non-Mac setup in bitcoingui.cpp

84f8551f3a

Merge pull request #3297

84f8551 [Qt] misc small Mac related changes/cleanups (Philip Kaufmann)

6694f4a7a2

rpcwallet: use EnsureWalletIsUnlocked() where possible

- replaces a pwalletMain->IsLocked() check
- in keypoolrefill init kpSize to 0 as we have the logic to determine max
  kpSize in pwalletMain->TopUpKeyPool() anyway

f914c7a1a4

Merge pull request #3178

f914c7a rpcwallet: use EnsureWalletIsUnlocked() where possible (Philip Kaufmann)

20a3c80790

Merge pull request #3207

666893b qt: keep a list of requested payments (Wladimir J. van der Laan)

955787f83f

Merge pull request #3368 from laanwj/2013_11_disable_wallet_mining

Allow mining RPCs with --disable-wallet

d47bbbd261

Add protobuf-compiler dependency package for debian

Fixes #3361

b9c3416723

Merge pull request #3378

b9c3416 Add protobuf-compiler dependency package for debian (Wladimir J. van der Laan)

fb96e28b29

Release process: add section about announcing new release 4f99b1601b

Merge pull request #3350

fdbdb7f cleanup includes in rpcnet.cpp (Philip Kaufmann)
b6aafca some string and indentation updates in init/rpcclient (Philip Kaufmann)

6939a0d50e

Update build-osx.md 9392924d0d

Merge pull request #3389 from regergregregerrge/patch-1

Update build-osx.md

ef20293c51

Merge pull request #3379

4f99b16 Release process: add section about announcing new release (Wladimir J. van der Laan)

69127034c3

[Qt] fix possibilty to delete last sendcoins entry

- hide the entry about to be deleted, and if it is the last entry add a
  new one, so that we always have one entry in our list

24646ee76f

Merge pull request #3382

24646ee [Qt] fix possibilty to delete last sendcoins entry (Philip Kaufmann)

5e47c2b70a

build: fix syntax error on older m4/autoconf.

Fixes #3358. This affects preinstalled autotools on osx 10.6.

b878b763cb

Use 'make check' instead of 'make test' 3f2c6f8654

Merge pull request #3395 from ldenman/patch-2

Use 'make check' instead of 'make test'

c4880e0172

Merge pull request #3393 from theuni/build-10.6

build: fix syntax error on older m4/autoconf.

fb34be6d59

Merge src/leveldb changes for LevelDB 1.15 ed873a301e

BitcoinPullTester commented at 9:28 pm on December 12, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ed873a301eeff8c021ba57c78fb702fd2b6f0452 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

jgarzik commented at 11:20 pm on December 12, 2013: contributor

ACK

sipa commented at 9:57 am on December 13, 2013: member

Just did a sync from scratch on LevelDB 1.15. All good.

laanwj commented at 11:48 am on December 14, 2013: member

Also did a sync from scratch for both testnet and mainnet. Works for me (TM).

laanwj referenced this in commit cf920b657d on Dec 17, 2013

laanwj merged this on Dec 17, 2013

laanwj closed this on Dec 17, 2013

DrahtBot locked this on Sep 8, 2021

LevelDB 1.15 #3405