fuzz: exercise ComputeMerkleRoot without mutated parameter #34050

pull l0rinc wants to merge 1 commits into bitcoin:master from l0rinc:l0rinc/merkle-merkle-root-without-mutated changing 1 files +1 −1
  1. l0rinc commented at 11:50 am on December 11, 2025: contributor

    The mutated parameter in ComputeMerkleRoot unlocks a different path that was always exercised in the fuzz test. Adjusted to be fuzzer to pass nullptr as well to make sure that path is also tested: https://github.com/bitcoin/bitcoin/blob/24ed820d4f0d8f7fa2f69e1909c2d98f809d2f94/src/consensus/merkle.cpp#L49-L53

    Follow-up to #33805 (review)

  2. fuzz: exercise `ComputeMerkleRoot` without mutated parameter
    Co-authored-by: sedited <seb.kung@gmail.com>
    7e9de20c0c
  3. DrahtBot added the label Tests on Dec 11, 2025
  4. DrahtBot commented at 11:50 am on December 11, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34050.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hodlinator, frankomosh, sedited

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  5. hodlinator approved
  6. hodlinator commented at 1:59 pm on December 11, 2025: contributor
    ACK 7e9de20c0c144f5ccea5efe6d90601dd72bc7461
  7. frankomosh commented at 4:06 pm on December 11, 2025: contributor
    ACK 7e9de20
  8. sedited approved
  9. sedited commented at 12:29 pm on December 16, 2025: contributor
    ACK 7e9de20c0c144f5ccea5efe6d90601dd72bc7461
  10. fanquake added the label Fuzzing on Dec 16, 2025
  11. fanquake merged this on Dec 16, 2025
  12. fanquake closed this on Dec 16, 2025

  13. l0rinc deleted the branch on Dec 16, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-23 03:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me