- was left out in #3326
update help for -blockmaxsize and blockprioritysize #3409
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:init changing 1 files +4 −3-
Diapolo commented at 7:51 AM on December 13, 2013: none
-
laanwj commented at 8:02 AM on December 13, 2013: member
Why are we hardcoding these numbers in the message instead of using the appropriate constants?
-
-
laanwj commented at 8:51 AM on December 13, 2013: member
Why not simply
strUsage += " -blockmaxsize=<n> " + strprintf(_("Set maximum block size in bytes (default: %d)"), DEFAULT_BLOCK_MAX_SIZE) + "\n"; strUsage += " -blockprioritysize=<n> " + strprintf(_("Set maximum size of high-priority/low-fee transactions in bytes (default: %d)"), DEFAULT_BLOCK_PRIORITY_SIZE) + "\n"; -
a9a37c8bb5
update help for -blockmaxsize and blockprioritysize
- was left out in #3326
-
Diapolo commented at 9:02 AM on December 13, 2013: none
Good suggestion... perhaps we can update all strings containing defaults in constants that way in the future.
- laanwj referenced this in commit 5e2fb330fd on Dec 13, 2013
- laanwj merged this on Dec 13, 2013
- laanwj closed this on Dec 13, 2013
-
BitcoinPullTester commented at 9:16 AM on December 13, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a9a37c8bb5b69df4d8270d27ce070f1b16f6ff6b for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
- Diapolo deleted the branch on Dec 16, 2013
- DrahtBot locked this on Sep 8, 2021
