test: Improve code coverage for pubkey checks #34099

1. 
   billymcbip commented at 12:25 pm on December 18, 2025: contributor

   Cover these branches in IsCompressedOrUncompressedPubKey and IsCompressedPubKey:

   • Non-canonical public key: invalid length for uncompressed key
   • Non-canonical public key: invalid length for compressed key
   • Non-canonical public key: invalid prefix for compressed key

   See the missed branches here: https://maflcko.github.io/b-c-cov/total.coverage/src/script/interpreter.cpp.gcov.html

   script_tests succeed on my end.

2. test: Improve code coverage for pubkey checks 6bb66fcccb
3. DrahtBot added the label Tests on Dec 18, 2025
4. 
   DrahtBot commented at 12:25 pm on December 18, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34099.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	rkrux, darosior, maflcko

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

5. 
   rkrux commented at 1:17 pm on December 18, 2025: contributor

   Nice, the coverage is available now here: https://corecheck.dev/bitcoin/bitcoin/pulls/34099.

   I can see the PR description mentioned functions of the interpreter file has increased coverage! I don’t know why the previous PR didn’t have the coverage available.

6. 
   billymcbip commented at 3:49 pm on December 18, 2025: contributor

   @rkrux perhaps my force push on the other PR broke the code coverage job.

   By the way, I also verified that the branches are being called by adding an assert(false) to those branches. script_tests then failed as expected.

7. 
   brunoerg commented at 6:25 pm on December 18, 2025: contributor

   I can see the PR description mentioned functions of the interpreter file has increased coverage! I don’t know why the previous PR didn’t have the coverage available.

   There was an issue with corecheck that hopefully has been fixed. See https://github.com/corecheck/corecheck/pull/148 and https://github.com/corecheck/corecheck/issues/143.

8. rkrux approved
9. 
   rkrux commented at 9:51 am on December 19, 2025: contributor

   code review ACK 6bb66fcccb5b65eada89578737ecada6f017fc5a

   The changes are same as the ones in the previous PR #34058.

10. 
    billymcbip commented at 2:04 pm on December 19, 2025: contributor

    @brunoerg thank you. Separately, I think lost and gained baseline coverage is wrong. It’s not plausible that my PR had as high an impact as https://corecheck.dev/bitcoin/bitcoin/pulls/34099 indicates.
11. 
    brunoerg commented at 4:46 pm on December 19, 2025: contributor

    @brunoerg thank you. Separately, I think lost and gained baseline coverage is wrong. It’s not plausible that my PR had as high an impact as https://corecheck.dev/bitcoin/bitcoin/pulls/34099 indicates.

    Yes, it’s wrong, see: https://github.com/corecheck/corecheck/issues/150

12. darosior approved
13. 
    darosior commented at 8:26 pm on January 13, 2026: member

    ACK 6bb66fcccb5b65eada89578737ecada6f017fc5a
14. 
    maflcko commented at 9:04 pm on January 13, 2026: member

    ACK 6bb66fcccb5b65eada89578737ecada6f017fc5a 🌑

    Signature:

    0untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
    1RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
    2trusted comment: ACK 6bb66fcccb5b65eada89578737ecada6f017fc5a 🌑
    3Fs6+hoZoEJWFFdV3J5KL2mjgnG7bkIQJNjLxkKyDaViRs0D/PRcp++0hlSA8+O/0g2hX+cvUx3byetNZYfZlAg==
    

15. glozow merged this on Jan 13, 2026
16. glozow closed this on Jan 13, 2026

    ---

17. billymcbip deleted the branch on Jan 14, 2026

Contributors
billymcbip DrahtBot rkrux brunoerg darosior maflcko

Labels
Tests