Make no-vin temporarily not a DoSable offence #3410

sipa commented at 9:56 AM on December 13, 2013: member

Since we've had a long standing bug that made certain clients produce completely empty transactions, I think we should remove the DoS ban from it temporarily. Those clients must have a hard time keeping persistent connections to the network.

laanwj commented at 10:48 AM on December 13, 2013: member

Hmm we should have done this for 0.8.6. What would be the timeframe on this? Would it still make sense to include this in 0.9 given that it will be released some time around 2014-02?

sipa commented at 10:49 AM on December 13, 2013: member

Agree, it should have been in 0.8.6. And indeed, if no 0.8.7 is needed (I hope not), this may be too late anyway.

jgarzik commented at 3:26 PM on December 13, 2013: contributor

+1

cozz commented at 12:18 PM on December 16, 2013: contributor

Is there an easy way to check, if my wallet contains such an empty transaction? Does it appear anywhere or is it hidden?

laanwj commented at 12:25 PM on December 16, 2013: member

@cozz It's hidden: part of the vtxPrev of a valid transaction. Tools such as jackjack's pywallet will not list them (although it could be adapted to do so, of course, but currently it ignores vtxPrevs).

cozz commented at 12:35 PM on December 16, 2013: contributor

Ok. Maybe we should add an if-statement to RelayTransaction(..). If tx is empty, do not relay. Could also be done in wallet.cpp, only for the vtxPrev.

cozz commented at 12:43 PM on December 16, 2013: contributor

Ah just saw you already did that in 0.8.6,

laanwj commented at 12:46 PM on December 16, 2013: member

Yes, has already been done for 0.8.6 and 0.9.x. They are not relayed and no new empty transactions will end up in wallets.

laanwj added the label P2P on Jul 31, 2014

sipa commented at 12:27 PM on July 31, 2014: member

I keep seeing nodes sending me empty vins...

laanwj commented at 12:49 PM on July 31, 2014: member

@sipa Yes, me too, only from <0.8.6 nodes though as expected.

kazcw commented at 11:16 PM on July 31, 2014: contributor

#4542 would prevent the DoS banning without needing a special exception to cover this case

laanwj commented at 8:42 AM on May 18, 2015: member

Closing this; 0.11 is about to be released, behavior for 0.8.x versions with broken wallets is no longer relevant.

laanwj closed this on May 18, 2015

MarcoFalke locked this on Sep 8, 2021