This is resolution to #3367, fixing incorrect github commit merge
fixed documentation on disabling/enabling hardening flags #3411
pull haltingstate wants to merge 1 commits into bitcoin:master from haltingstate:master changing 1 files +4 −1-
haltingstate commented at 11:44 AM on December 13, 2013: contributor
-
laanwj commented at 11:57 AM on December 13, 2013: member
Can you please give the commit a more descriptive name instead of "Changes" ?
BTW you don't have to open a new pull request if you make a change, you can just re-push to the same branch and the existing pull will be updated.
-
haltingstate commented at 12:08 PM on December 13, 2013: contributor
"BTW you don't have to open a new pull request if you make a change, you can just re-push to the same branch and the existing pull will be updated."
No. The repo was corrupted. The original pull request was not listed in the set of pull requests on github. I had to delete the repo and then recreate it and there was a 501 error. I had to contact technical support. The pull request was no longer associated with the repo.
There was no option for amending the pull request and the previous branch no longer existed.
On Fri, Dec 13, 2013 at 3:59 AM, BitcoinPullTester <notifications@github.com
wrote:
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/1d2feb2da68c7ccd69b4b3d74eaaa65b5715a3e8for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
— Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/pull/3411#issuecomment-30504509 .
-
fixed documetation on hardening flags 08b93f9a65
-
haltingstate commented at 12:10 PM on December 13, 2013: contributor
I renamed the commit message.
-
BitcoinPullTester commented at 12:40 PM on December 13, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/08b93f9a65ce70e650244f94725fcd042d97f0ee for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
- laanwj referenced this in commit 6bfaf2ac37 on Dec 13, 2013
- laanwj merged this on Dec 13, 2013
- laanwj closed this on Dec 13, 2013
- DrahtBot locked this on Sep 8, 2021