Enable misc RPCs in --disable-wallet compiles #3412

pull laanwj wants to merge 7 commits into bitcoin:master from laanwj:2013_12_enable_rpcs_nowallet2 changing 13 files +366 −329

laanwj commented at 3:38 PM on December 13, 2013: member

Some RPC functions were in rpcwallet.cpp but don't really require the wallet, so can be enabled. Similarly, settxfee is pointless without the wallet so disable it.

Fixes #3406
add new RPC implementation file `rpcmisc.cpp` 652e156951

Move `getinfo` from rpcnet to rpcmisc

`getinfo` is a general info method which shows information
from multiple sources, it doesn't belong in rpcnet.cpp or
any of the other current RPC implementation files.

16bc9aaf8a

Move `settxfee` from rpcblockchain to rpcwallet
`settxfee` only affects the wallet, not the block chain.
a943bde6f0

Move `nTransactionFee` from main.cpp to wallet.cpp

Transaction fee is only used by the wallet.
No need for it to be in main.cpp.

cd7fa8bb43

Move `validateaddress` from rpcwallet to rpcmisc

Enables it in --disable-wallet compiles.
Delimit wallet-using part using #ifdef ENABLE_WALLET.

452955f5be

Move `createmultisig` from rpcwallet to rpcmisc
Enables it in --disable-wallet compiles.
723a03d2de
Move `verifymessage` from rpcwallet to rpcmisc
Enables it in --disable-wallet compiles.
c3a7f516e7
jgarzik commented at 3:43 PM on December 13, 2013: contributor

ACK
BitcoinPullTester commented at 3:52 PM on December 13, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c3a7f516e7ba9f39537ded149d8eb756c836fa2e for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 1:00 PM on December 15, 2013: member

Haven't tested or checked that the move commits are move-only, but design ACK.
laanwj referenced this in commit 285cf7a1a6 on Dec 19, 2013
laanwj merged this on Dec 19, 2013
laanwj closed this on Dec 19, 2013
laanwj deleted the branch on Apr 9, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#3406 ENABLE_WALLET hides !wallet features, misses others