Minor follow-up to #33866
Reuse the should_empty predicate for both the write decision and for selecting CoinsTip().Flush() vs CoinsTip().Sync().
This is a pure refactor, no behavior is changed.
refactor: reuse `should_empty` check for chainstate flush #34125
pull l0rinc wants to merge 1 commits into bitcoin:master from l0rinc:l0rinc/reuse-should-empty changing 1 files +8 −4-
l0rinc commented at 12:14 PM on December 20, 2025: contributor
- DrahtBot added the label Refactoring on Dec 20, 2025
-
DrahtBot commented at 12:14 PM on December 20, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34125.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #33680 (validation: do not wipe utxo cache for stats/scans/snapshots by l0rinc)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- DrahtBot added the label Needs rebase on Jan 3, 2026
- l0rinc force-pushed on Jan 3, 2026
- l0rinc renamed this:
refactor: reuse `should_empty` for chainstate flush condition
validation: reuse `should_empty` check for chainstate flush
on Jan 3, 2026 -
66ab897866
validation/refactor: reuse `should_empty` for chainstate flush condition
In `Chainstate::FlushStateToDisk`, the condition for emptying the UTXO cache was duplicated: once in `should_write` and again when choosing between `CoinsTip().Flush()` and `CoinsTip().Sync()`. Compute it once as `should_empty` and reuse it in both places.
- l0rinc force-pushed on Jan 3, 2026
-
- l0rinc marked this as ready for review on Jan 3, 2026
- DrahtBot added the label CI failed on Jan 3, 2026
- DrahtBot removed the label Needs rebase on Jan 3, 2026
- DrahtBot removed the label CI failed on Jan 3, 2026
- l0rinc renamed this:
validation: reuse `should_empty` check for chainstate flush
refactor: reuse `should_empty` check for chainstate flush
on Jan 20, 2026 - DrahtBot added the label Needs rebase on Jan 30, 2026
-
DrahtBot commented at 12:06 AM on January 30, 2026: contributor
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
-
l0rinc commented at 9:15 AM on January 30, 2026: contributor
- l0rinc closed this on Jan 30, 2026
Labels