Remove two unused methods from ui_interface #3415

pull laanwj wants to merge 3 commits into bitcoin:master from laanwj:2013_12_uiinterface_remove_unused_method changing 8 files +8 −56

laanwj commented at 11:32 AM on December 14, 2013: member
- Remove unused ThreadSafeHandleURI from ui_interface
- Remove unused ThreadSafeAskFee from ui_interface
  
  ThreadSafeAskFee is effectively unused. It is only called when the fAskFee parameter on SendMoney or SendMoneyToDestination is true, which never happens (it is always used in the default which is false). Remove it.
Remove unused ThreadSafeHandleURI from ui_interface 37e67d37c1

Remove unused ThreadSafeAskFee from ui_interface

ThreadSafeAskFee is effectively unused. It is only called
when the fAskFee parameter on SendMoney or SendMoneyToDestination
is true, which never happens. Remove it.

ca2c83da50

sipa commented at 12:55 PM on December 15, 2013: member

How did they become unused?
laanwj commented at 12:57 PM on December 15, 2013: member

By @jonasschnelli's GUI changes to show the fee in the confirmation dialog instead of in a seperate dialog.

qt: status WalletModel::Aborted is no longer used

Aborting transactions happens in the GUI now as it should,
not the backend.

4a61c39456

BitcoinPullTester commented at 9:51 AM on December 16, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4a61c39456b553f7de8ccc019276d40aff10dac0 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 10:17 AM on December 16, 2013: none

I´ve asked me the same about ThreadSafeAskFee and came to the conclusion it's unused, but had no time to create a patch. ACK, didn't test.
laanwj referenced this in commit 57fdd68aac on Dec 18, 2013
laanwj merged this on Dec 18, 2013
laanwj closed this on Dec 18, 2013
laanwj referenced this in commit 636a42bd0e on Dec 18, 2013
laanwj deleted the branch on Apr 9, 2014
MathyV referenced this in commit abf6e0690e on Aug 5, 2014
DrahtBot locked this on Sep 8, 2021

Contributors