Membership tests of the form not item in stuff may be confusing, because they could be read as (not item) in stuff, which is different.
So enable the ruff E713 lint, which should also help to avoid having to go through review cycles for this.
Membership tests of the form not item in stuff may be confusing, because they could be read as (not item) in stuff, which is different.
So enable the ruff E713 lint, which should also help to avoid having to go through review cycles for this.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34154.
See the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
lgtm crACK fab300b378941a233119805c0d62198596a57790
So enable the ruff E713 lint, which should also help to avoid having to go through review cycles for this.
Thanks for enabling it globally, unrelated lint changes were indeed distracting in #33014 (review).
ACK fab300b378941a233119805c0d62198596a57790
x not in y is clearer than not x in y - good to have this enforced.
Recreated the change locally, ended up with the same state.
ACK fab300b378941a233119805c0d62198596a57790