test: Enable ruff E713 lint #34154

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2512-ruff-E713 changing 10 files +18 −17
  1. maflcko commented at 7:26 am on December 26, 2025: member

    Membership tests of the form not item in stuff may be confusing, because they could be read as (not item) in stuff, which is different.

    So enable the ruff E713 lint, which should also help to avoid having to go through review cycles for this.

  2. test: Enable ruff E713 lint fab300b378
  3. DrahtBot added the label Tests on Dec 26, 2025
  4. DrahtBot commented at 7:26 am on December 26, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34154.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK rkrux, bensig, l0rinc

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #34098 (test: [move-only] Move lint functions into modules by maflcko)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. rkrux approved
  6. rkrux commented at 8:31 am on December 26, 2025: contributor

    lgtm crACK fab300b378941a233119805c0d62198596a57790

    So enable the ruff E713 lint, which should also help to avoid having to go through review cycles for this.

    Thanks for enabling it globally, unrelated lint changes were indeed distracting in #33014 (review).

  7. bensig commented at 7:16 am on January 3, 2026: contributor

    ACK fab300b378941a233119805c0d62198596a57790

    x not in y is clearer than not x in y - good to have this enforced.

  8. l0rinc commented at 10:05 pm on January 3, 2026: contributor

    Recreated the change locally, ended up with the same state.

    ACK fab300b378941a233119805c0d62198596a57790

  9. fanquake merged this on Jan 4, 2026
  10. fanquake closed this on Jan 4, 2026

  11. maflcko deleted the branch on Jan 5, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-07 03:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me