Remove -logtodebugger option #3416

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_12_remove_logtodebugger changing 4 files +4 −32
  1. laanwj commented at 12:55 PM on December 14, 2013: member

    (as discussed in #3377) -logtodebugger is a strange, obscure, WIN32-only (mostly MSVC) thing. It went untested for a long time, so I'm pretty sure that noone is using it. Let's clean up the options a bit get rid of it.

    test_bitcoin was using fLogToDebugger as a way to prevent logging to debug.log. For this, add a boolean (not exposed as option) fLogToDebugLog that defaults to true and is disabled in the tests.

  2. Remove -logtodebugger
    `-logtodebugger` is a strange, obscure, WIN32-only (mostly MSVC) thing.
    Let's clean up the options a bit get rid of it.
    
    test_bitcoin was using fLogToDebugger as a way to prevent logging to
    debug.log. For this, add a boolean (not exposed as option) fLogToDebugLog that
    defaults to true and is disabled in the tests.
    9e9056cd1a
  3. BitcoinPullTester commented at 9:52 AM on December 15, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/9e9056cd1a05e5868025553d2a8cb3e47cf45045 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  4. sipa commented at 12:55 PM on December 15, 2013: member

    Untested ACK.

  5. Diapolo commented at 8:19 AM on December 20, 2013: none

    I've also never used this (and don't use MSVC), so ACK on removing it.

  6. laanwj referenced this in commit f498d43ee2 on Dec 20, 2013
  7. laanwj merged this on Dec 20, 2013
  8. laanwj closed this on Dec 20, 2013

  9. laanwj deleted the branch on Apr 9, 2014
  10. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me