tests: add concise docstrings in chain_tiebreaks #34167

1. 
   Olly60 commented at 9:45 pm on December 28, 2025: none

   Added concise docstrings for test_chain_split_in_memory and test_chain_split_from_disk
2. tests: add concise docstrings in chain_tiebreaks 7f177280fd
3. DrahtBot added the label Tests on Dec 28, 2025
4. 
   DrahtBot commented at 9:45 pm on December 28, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34167.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

5. in test/functional/feature_chain_tiebreaks.py:107 in 7f177280fd

   103@@ -103,6 +104,7 @@ def test_chain_split_in_memory(self):
   104         node.invalidateblock(blocks[0].hash_hex)
   105 
   106     def test_chain_split_from_disk(self):
   107+        """Test active chain selection with in-memory forks and out-of-order blocks."""
   

   ---

   ---

   

   billymcbip commented at 3:09 pm on December 30, 2025:

   Shouldn’t it be “on-disk forks” rather than “in-memory forks”?

   ---

   

   bensig commented at 6:25 am on January 1, 2026:

   +1 on @billymcbip’s observation, looks like copypasta

   ---

   

   Olly60 commented at 1:07 pm on January 1, 2026:

   +1 on @billymcbip’s observation, looks like copypasta

   My bad I should I thought it was that. I’ll make sure I double check next time

6. Fix docstring: on-disk forks (not in-memory) 87ca084518
7. DrahtBot added the label CI failed on Jan 2, 2026
8. DrahtBot removed the label CI failed on Jan 2, 2026
9. 
   maflcko commented at 8:25 am on January 5, 2026: member

   Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

   Though, I think the code is already self-documenting. So thx, but i think i’ll close this for now.

10. maflcko closed this on Jan 5, 2026

    ---

Contributors
Olly60 DrahtBot billymcbip bensig maflcko

Labels
Tests