Fix intermittent issue in p2p_1p1c_network.py #34172

1. 
   instagibbs commented at 3:17 pm on December 29, 2025: member

   Resolves #33318 in a minimal fashion. Given that the orphan transactions aren’t being persisted anymore, I’m not that specific case offers much coverage, but kept it around for now to get rid of the timeouts at least.
2. 
   DrahtBot commented at 3:17 pm on December 29, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34172.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	glozow

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

3. instagibbs force-pushed on Dec 29, 2025
4. DrahtBot added the label CI failed on Dec 29, 2025
5. instagibbs force-pushed on Dec 29, 2025
6. 
   glozow commented at 3:36 pm on December 29, 2025: member

   First commit might not make a difference for the flakiness, but is an improvement to the test after #33892.

   ACK cc589d8fa4c90444968eb2365669546ab15b9f94

7. 
   instagibbs commented at 3:46 pm on December 29, 2025: member

   @glozow don’t recall if this actually caused flakiness, but it definitely violated the assumptions of the test: https://github.com/bitcoin/bitcoin/pull/34172/files#diff-303ce8833aaae92cea51cf00a5f56f7a9a1f3b9cab11576d41d63a403bf4e335L71

   explicit 1sat/vbyte minrelay assumption

8. instagibbs force-pushed on Dec 29, 2025
9. test: change low fee parents to 0-fee

   The test is harder to read, and had an explicit 1sat/vbyte
   floor assumption in a single place which is incorrect. Using
   0-fee makes the test more future proof.

   25e84d3772
10. test: ensure clean orphanage before continuing

    The tests were written assuming transaction orphans would
    persist for a time beyond the test peer's disconnection.
    After #31829 this no longer holds, so as a minimal fix we
    modify the test to wait until the orphans are removed before
    continuing with the final transaction submissions.

    95ef0fc5e7
11. instagibbs force-pushed on Dec 29, 2025
12. 
    glozow commented at 4:36 pm on December 29, 2025: member

    utACK 95ef0fc5e78146e367e9454ba6b2899503631858
13. DrahtBot removed the label CI failed on Dec 29, 2025
14. fanquake added this to the milestone 31.0 on Dec 29, 2025
15. fanquake merged this on Dec 31, 2025
16. fanquake closed this on Dec 31, 2025

    ---

Contributors
instagibbs DrahtBot glozow

Milestone
31.0