. #34173
pull jummon-koshai wants to merge 2 commits into bitcoin:master from jummon-koshai:improve-wait-until changing 2 files +220 −25-
jummon-koshai commented at 3:54 pm on December 29, 2025: none.
-
Enhance wait_until_helper_internal with adaptive timeout and telemetry fef3fe2928
-
Add functional tests for enhanced wait_until_helper_internal 6f737b1c5e
-
DrahtBot commented at 3:54 pm on December 29, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34173.
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
LLM Linter (✨ experimental)
Possible places where comparison-specific test macros should replace generic comparisons:
- test/functional/test_framework/test_util_wait_until.py: assert counter[“count”] >= 3 -> use assert_greater_than_or_equal(counter[“count”], 3)
- test/functional/test_framework/test_util_wait_until.py: assert len(history) > 0 -> use assert_greater_than(len(history), 0)
2025-12-29
-
in test/functional/test_framework/util.py:490 in 6f737b1c5e
509+ 510+ num_fails = sum( 511+ 1 for _, r in local_history 512+ if (not all(r) if isinstance(r, list) else not r) 513+ ) 514+ logger.info(f"AI-assisted insight: Predicate failed {num_fails}/{len(local_history)} times. Possible flaky timing issue.")
fjahr commented at 5:20 pm on December 29, 2025:Human insight: please don’t open PRs like this. None of this seems actually useful and if it were you should be able to point to where these changes to the framework do actually improve the test suite.pinheadmz closed this on Dec 29, 2025
pinheadmz commented at 5:34 pm on December 29, 2025: memberAI slopbitcoin locked this on Dec 29, 2025fanquake renamed this:
Enhance wait_until_helper_internal with adaptive timeout, telemetry, and functional tests
.
on Dec 29, 2025
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-07 03:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-07 03:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me