IsWellFormedPackage
#34177
IsWellFormedPackage() already claims: “parents must appear before children.” In practice the require_sorted argument was always passed as true, making the false-path dead code. It was introduced that way from the beginning in https://github.com/bitcoin/bitcoin/pull/28758/files#diff-f30090b30c9489972ee3f1181c302cf3a484bb890bade0fd7c9ca92ea8d347f6R79.
Remove the unused parameter, updating callers/tests.
`IsWellFormedPackage()` already claims: "parents must appear before children."
In practice the `require_sorted` argument was always passed as `true`, making the false-path dead code.
It was introduced that way from the beginning in https://github.com/bitcoin/bitcoin/pull/28758/files#diff-f30090b30c9489972ee3f1181c302cf3a484bb890bade0fd7c9ca92ea8d347f6R79.
Remove the unused parameter, updating callers/tests.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34177.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | billymcbip, instagibbs |
If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.
tACK 658d38106a397ca04b94d98de57afc4de140feaa
require_sorted argument is true in all call sites, making this a straightforward refactor.
ACK 658d38106a397ca04b94d98de57afc4de140feaa
I believe this functionality was intended to be used in a https://github.com/bitcoin/bips/blob/master/bip-0331.mediawiki like package relay scheme. Given that it has no test coverage and is unused, makes sense to remove. It can be reintroduced at any time with more advanced relay schemes.
