Spotted a few duplicated words while reading through the code:
- "the the" in mempool_stress.cpp
- "to to" in txgraph.cpp
- "for for" in cluster_linearize.h
- "that that" in txrequest.h
- "in in" in test/fuzz/txgraph.cpp
Spotted a few duplicated words while reading through the code:
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34183.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
We don't usually add these separately - they take up review time, which is already very scarce - but we might as well get rid of these. ACK 08ed802babb5cdda6fa61c4e50a0e6fb92a6f434
lgtm ACK 08ed802babb5cdda6fa61c4e50a0e6fb92a6f434
24 | @@ -25,7 +25,7 @@ 25 | * - Which peer announced it (through their NodeId) 26 | * - The txid or wtxid of the transaction (collectively called "txhash" in what follows) 27 | * - Whether it was a tx or wtx announcement (see BIP339). 28 | - * - What the earliest permitted time is that that transaction can be requested from that peer (called "reqtime"). 29 | + * - What the earliest permitted time is that the transaction can be requested from that peer (called "reqtime").
nit: I suggest making it even more concise:
The earliest permissible request time for that transaction from that peer ("reqtime").
That would have been even better.