Fix unit test error on OSX 10.9 using Apple LLVM v5.0. #3420

( Next time, I will re-push to the same branch instead of closing and opening pull requests. )

Before the fix, there were 6 errors such as : serialize_tests.cpp:77: error in "noncanonical": incorrect exception std::ios_base::failure is caught

It turns out that ex.what() returns following string instead of "non-canonical ReadCompactSize()" "non-canonical ReadCompactSize(): unspecified iostream_category error"

After the fix, unit test passed.

The test ran using Apple LLVM v5.0 on OSX 10.9 and the unit test error happened because of different error messages by different compilers.

g++ --version on my development environment.

Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 5.0 (clang-500.2.79) (based on LLVM 3.3svn)
Target: x86_64-apple-darwin13.0.0
Thread model: posix

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/bccd5324ab5b76c21b01bfe9c8ec7ab2061c93e4 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

ACK, though I expect that maybe we'll need to update this further in future, based on runtime environments.

A more long-term solution is perhaps introducing an own exception class for this, and checking it specifically.

Agreed with sipa, currently the test case was the only case expecting a specific type of exception thrown. Thanks sipa for the comment!