doc: p2p: replace last remaining “command” terminology with “message type” #34203

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202601-doc-p2p-command-afuera changing 2 files +5 −5
  1. theStack commented at 3:21 pm on January 5, 2026: contributor

    This small PR is (presumably) the final one in a long series of replacing the confusing “command” terminology with “message type” when referring to the header field of P2P messages, see #18533, #18937, #24078, #24141 and #31163.

    The instances were found manually via $ git grep -i command, hope I didn’t miss any.

  2. DrahtBot added the label Docs on Jan 5, 2026
  3. DrahtBot commented at 3:21 pm on January 5, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34203.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK l0rinc, billymcbip, maflcko

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

    LLM Linter (✨ experimental)

    Possible typos and grammar issues:

    • starts -> start [“sendheaders” message type and announcing blocks with headers are two things, so the verb should be plural: “start”]

    2026-01-05

  4. in src/net_processing.cpp:4949 in 1485a0bec7
    4944@@ -4945,8 +4945,8 @@ void PeerManagerImpl::ProcessMessage(CNode& pfrom, const std::string& msg_type,
    4945         return;
    4946     }
    4947 
    4948-    // Ignore unknown commands for extensibility
    4949-    LogDebug(BCLog::NET, "Unknown command \"%s\" from peer=%d\n", SanitizeString(msg_type), pfrom.GetId());
    4950+    // Ignore unknown message types for extensibility
    4951+    LogDebug(BCLog::NET, "Unknown message type \"%s\" from peer=%d\n", SanitizeString(msg_type), pfrom.GetId());
    


    maflcko commented at 3:45 pm on January 5, 2026:
    0    LogDebug(BCLog::NET, "Unknown message type \"%s\" from peer=%d", SanitizeString(msg_type), pfrom.GetId());
    

    theStack commented at 4:03 pm on January 5, 2026:
    Thanks, done.
  5. theStack force-pushed on Jan 5, 2026
  6. DrahtBot added the label CI failed on Jan 5, 2026
  7. l0rinc commented at 4:39 pm on January 5, 2026: contributor

    It seems to me we should probably update a leftover comment as well: https://github.com/bitcoin/bitcoin/blob/755f0900a28a874a65fb843c74d8257f96b667dc/src/net_processing.cpp#L5304

    Otherwise ACK ae9b44cb765de474e08276b404fd0381068d00f7

  8. doc: p2p: replace last remaining "command" terminology with "message type" 5b7bf47f9b
  9. theStack force-pushed on Jan 5, 2026
  10. theStack commented at 5:01 pm on January 5, 2026: contributor
    @l0rinc: Good catch, missed that one. Updated as well.
  11. l0rinc commented at 5:02 pm on January 5, 2026: contributor
    ACK 5b7bf47f9b92f5d4483a69d0682797e8cf483434
  12. billymcbip commented at 5:04 pm on January 5, 2026: contributor

    ACK 5b7bf47f9b92f5d4483a69d0682797e8cf483434

    Makes sense as a follow-up to #18533 and related PRs.

  13. DrahtBot removed the label CI failed on Jan 5, 2026
  14. maflcko commented at 7:17 am on January 6, 2026: member
    lgtm ACK 5b7bf47f9b92f5d4483a69d0682797e8cf483434
  15. fanquake merged this on Jan 6, 2026
  16. fanquake closed this on Jan 6, 2026

  17. theStack deleted the branch on Jan 6, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-22 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me