contrib: Fix Python issues in makeseeds.py #34217

pull tboy1337 wants to merge 1 commits into bitcoin:master from tboy1337:seed-script-fixes changing 1 files +6 −7
  1. tboy1337 commented at 8:16 am on January 7, 2026: none

    This PR addresses several code quality issues in the contrib/seeds/makeseeds.py script:

    Changes

    • Remove unused variable: Eliminate unused i variable in the filterbyasn function enumeration
    • Simplify control flow: Remove unnecessary else clause after return statement in parseline function
    • Fix file encoding: Add explicit UTF-8 encoding specification to file operations for better cross-platform compatibility
    • Correct type annotation: Fix incorrect type annotation for asn_count dictionary that was causing type checking errors

    Testing

    • Verified the script compiles successfully after changes
    • Confirmed pylint score improved from 8.59/10 to 8.78/10
    • No functional changes to the seed generation logic

    Motivation

    These changes improve code maintainability and fix compatibility issues without altering the core functionality of the seed generation process.

  2. contrib: Fix Python issues in makeseeds.py
    - Remove unused variable in filterbyasn function
    - Remove unnecessary else after return in parseline function
    - Add explicit UTF-8 encoding to file operations
    - Fix incorrect type annotation for asn_count dictionary
    eaa95788d7
  3. DrahtBot added the label Scripts and tools on Jan 7, 2026
  4. DrahtBot commented at 8:16 am on January 7, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34217.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  5. fanquake closed this on Jan 7, 2026

  6. tboy1337 deleted the branch on Jan 7, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-21 00:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me