qa: tool_bench_sanity_check.py --bench=MempoolCheck failure #34248

issue hebasto openend this issue on January 10, 2026
  1. hebasto commented at 1:16 pm on January 10, 2026: member

    On NetBSD 10.1, https://github.com/hebasto/bitcoin-core-nightly/actions/runs/20872235098/job/59975888965:

     090/455 - tool_bench_sanity_check.py --bench=MempoolCheck failed, Duration: 26 s
     1
     2stdout:
     32026-01-10T04:19:37.691064Z TestFramework (INFO): PRNG seed is: 4615966168349338210
     42026-01-10T04:19:37.692250Z TestFramework (INFO): Initializing test directory /home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/test_runner__🏃_20260110_041921/tool_bench_sanity_check_363
     52026-01-10T04:19:37.692513Z TestFramework (INFO): Starting: /home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/build/bin/bench_bitcoin -filter=MempoolCheck -sanity-check
     6Running with -sanity-check option, output is being suppressed as benchmark results will be useless.
     72026-01-10T04:19:38.567933Z TestFramework (INFO): Success!
     82026-01-10T04:20:03.637759Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
     9        wait_until_helper_internal(lambda: not self.network_event_loop.is_running(), timeout=timeout)
    10'''
    11
    12
    13stderr:
    14Traceback (most recent call last):
    15  File "/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/build/test/functional/tool_bench_sanity_check.py", line 41, in <module>
    16    BenchSanityCheck(__file__).main()
    17    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
    18  File "/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/test/functional/test_framework/test_framework.py", line 154, in main
    19    exit_code = self.shutdown()
    20  File "/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/test/functional/test_framework/test_framework.py", line 281, in shutdown
    21    self.network_thread.close()
    22    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
    23  File "/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/test/functional/test_framework/p2p.py", line 749, in close
    24    wait_until_helper_internal(lambda: not self.network_event_loop.is_running(), timeout=timeout)
    25    ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    26  File "/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/test/functional/test_framework/util.py", line 420, in wait_until_helper_internal
    27    raise AssertionError("Predicate {} not true after {} seconds".format(predicate_source, timeout))
    28AssertionError: Predicate ''''
    29        wait_until_helper_internal(lambda: not self.network_event_loop.is_running(), timeout=timeout)
    30''' not true after 10.0 seconds
    
  2. hebasto added the label Tests on Jan 10, 2026
  3. maflcko commented at 3:29 pm on January 10, 2026: member
    Not sure how this could happen. After https://github.com/bitcoin/bitcoin/commit/39ca01525977e5aab078198874f6bf035b552b3b , the test waits for the loop to be running, so a stop should always be called on a running loop and result in it eventually not running.


hebasto maflcko

Labels
Tests


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-12 00:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me