The current transaction loading code is not exception safe. An exception during deserialization causes an empty transaction to be left behind in the wallet.
Fix this by building the transaction separately and adding it only to the wallet at the end.
Fixes #3333. Should also be backported to 0.8.7 if we roll one.
The current transaction loading code is not exception safe.
An exception during deserialization causes an empty transaction
to be left behind in the wallet.
Fix this by building the transaction separately and adding
it only to the wallet at the end.
Fixes #3333.
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/16ec9044d1f2eda7c5c86fcb73c839e17fb35db3 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Untested ACK.
Shouldn't this get some more attention, as it fixes a serious bug.