contrib: Remove unused functions #34260

1. 
   maflcko commented at 8:14 am on January 12, 2026: member

   • remove_files is unused since 5668c6473a01528ac7d66b325b18b1cd2bd93063
   • download_lines_with_urllib is unused since it was introduced in 37c9fb7a59a3179b90ed1deaebaabb539976504b
   • determine_wellknown_cmd is unused since 76c090145e9bb64fe4ef6a663723dd0e9028ed10
2. contrib: Remove unused functions facaf56214
3. DrahtBot renamed this:
   contrib: Remove unused functions
   contrib: Remove unused functions
   on Jan 12, 2026
4. DrahtBot added the label Scripts and tools on Jan 12, 2026
5. 
   DrahtBot commented at 8:14 am on January 12, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34260.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fjahr, bensig, l0rinc

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #34247 (security: harden CI actions and subprocess calls by RinZ27)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. 
   fjahr commented at 1:38 pm on January 12, 2026: contributor

   ACK facaf5621446d819440f5a873848c01c848c3ecc

   I didn’t find any leftover references to the removed functions.

7. 
   bensig commented at 9:07 pm on January 12, 2026: contributor

   ACK facaf5621446d819440f5a873848c01c848c3ecc straightforward
8. l0rinc approved
9. 
   l0rinc commented at 9:57 pm on January 12, 2026: contributor

   Reproduced it locally, ACK facaf5621446d819440f5a873848c01c848c3ecc

   Q: unrelated, found while looking for unused stuff: what’s up with contrib/verify-binaries/test.py (cc: @stickies-v)? It seems it isn’t documented anywhere and hasn’t been updated since v22: https://github.com/bitcoin/bitcoin/pull/30147/changes#diff-90cbd281645f13450471e8841a5a197b959592f598998836c3bc3fda4d8e62c8R20

10. 
    maflcko commented at 7:10 am on January 13, 2026: member

    Q: unrelated, found while looking for unused stuff: what’s up with contrib/verify-binaries/test.py

    I think it is only changed and run, when the verify.py script is modified, to test it.

11. glozow merged this on Jan 13, 2026
12. glozow closed this on Jan 13, 2026

    ---

13. maflcko deleted the branch on Jan 14, 2026

Contributors
maflcko DrahtBot fjahr bensig l0rinc

Labels
Scripts and tools