When a InitError or InitWarning happens, the GUI pops up but is unusable (until Init finishes).
This is caused by showNormalIfMinimized. Add a message flag to skip this call for Init errors or warnings.
qt: Prevent non-functional GUI from popping up during Init #3427
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_12_qt_init_error changing 3 files +9 −4-
laanwj commented at 5:19 PM on December 16, 2013: member
-
1ad26362c9
qt: Prevent non-functional GUI from popping up during Init
When a InitError or InitWarning happens, the GUI pops up but is unusable (until Init finishes). This is caused by showNormalIfMinimized. Add a message flag to skip this call for Init errors or warnings.
-
BitcoinPullTester commented at 6:26 PM on December 16, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/1ad26362c92c7d5678c24df85fd7b9ab1d3d34fe for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
-
-
Diapolo commented at 8:52 PM on December 16, 2013: none
Looks sane, not tested, but ACK.
Edit: Currently testing this one ;).
-
Diapolo commented at 8:18 AM on December 20, 2013: none
ACK, tested and verified to work... I still get a crash when bitcoin-qt.exe aborts on error (unrelated to this pull) as I have no changce debugging that one further (global object destruction I guess related to some boost::path).
- laanwj referenced this in commit 362755d018 on Dec 23, 2013
- laanwj merged this on Dec 23, 2013
- laanwj closed this on Dec 23, 2013
- laanwj deleted the branch on Apr 9, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors