wallet: remove outdated RewriteDB calls from SPKM & DBErrors::NEED_REWRITE enum value #34301

1. 
   rkrux commented at 10:11 am on January 15, 2026: contributor

   ISTM that there is no implementation left of the RewriteDB method in any of the SPKMs, and thus, its call sites can be removed safely.

   Also remove DBErrors::NEED_REWRITE enum value as its usage is outdated now.

2. DrahtBot added the label Wallet on Jan 15, 2026
3. 
   DrahtBot commented at 10:11 am on January 15, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34301.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	achow101

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

   Conflicts

   No conflicts as of last run.

4. 
   achow101 commented at 9:09 pm on January 15, 2026: member

   Concept ACK

   I think this can actually extend a bit futher into getting rid of DBErrors::NEED_REWRITE entirely. This only exists for wallets created in 0.4.x which had the bug that the database was not rewritten. However, given that BDB is no longer supported at all and migration is explicitly a rewrite anyways, there’s actually no situation in which NEED_REWRITE being returned is ever doing anything useful.

   The only places we should ever need WalletDatabase::Rewrite are in wallet encryption.

5. rkrux renamed this:
   wallet: remove unimplemented `RewriteDB` calls from SPKM
   wallet: remove outdated `RewriteDB` calls from SPKM & `DBErrors::NEED_REWRITE` enum value
   on Jan 16, 2026
6. 
   rkrux commented at 11:02 am on January 16, 2026: contributor

   I think this can actually extend a bit futher into getting rid of DBErrors::NEED_REWRITE entirely.

   Thanks, I have added a commit addressing this point.

7. 
   achow101 commented at 9:01 pm on January 19, 2026: member

   ACK 5c802c73c0d40cf327bbe3333853b9ebfb5b7563
8. DrahtBot added the label Needs rebase on Feb 4, 2026
9. wallet: remove unimplemented `RewriteDB` calls from SPKM

   ISTM that there is no implementation left of the `RewriteDB` method
   in any of the SPKMs, and thus, its call sites can be removed safely.

   61039d72a5
10. wallet: remove `DBErrors::NEED_REWRITE` enum value

    As highlighted in the PR review comment, this enum seems no longer
    required as the specific issue it solves for involves BDB based wallets
    that can't be loaded anymore outside the context of wallet migration,
    which rewrites the database anyway.

    c6a6435ced
11. rkrux force-pushed on Feb 5, 2026
12. DrahtBot removed the label Needs rebase on Feb 5, 2026
13. 
    achow101 commented at 6:38 pm on February 5, 2026: member

    ACK c6a6435cedac01a6800cac9285e2c599290e2e0d

Contributors
rkrux DrahtBot achow101

Labels
Wallet