qt: Treat regtest as testnet #3437

laanwj commented at 8:47 AM on December 18, 2013: member

No need to do anything special in the GUI for regtest mode, but do treat it as testnet not mainnet to prevent confusion.

Diapolo commented at 12:37 PM on December 18, 2013: none

General ACK, what happened with RPCConsole? Can you post a screen?

laanwj commented at 12:40 PM on December 18, 2013: member

Nothing major, it just shows the network name instead of a checkbox.

Why not test it yourself?

Diapolo commented at 12:50 PM on December 18, 2013: none

I observerd that a screenshot helps getting ACKs without the need to test an uncontroversial pull.

laanwj commented at 12:57 PM on December 18, 2013: member

But the point of pull requests is also that people help test them

I always test pulls before merging, but for my own pulls it helps if someone else does it too.

Diapolo commented at 1:01 PM on December 18, 2013: none

I got the point, often I don't take the time to really test every single Qt-pull, but mainly the "big ones". I'm trying to re-think this and yes, I understand you.

in src/qt/bitcoin.cpp:None in f7e576f17a outdated

 170 | @@ -171,7 +171,7 @@ int main(int argc, char *argv[])
 171 |      } else {
 172 |          ReadConfigFile(mapArgs, mapMultiArgs);
 173 |      }
 174 | -    // Check for -testnet or -regtest parameter (TestNet() calls are only valid after this clause)
 175 | +    // Check for -testnet or -regtest parameter (TestNet() and RegTest() calls are only valid after this clause)
 176 |      if (!SelectParamsFromCommandLine()) {

Diapolo commented at 8:22 AM on December 20, 2013:

Should this comment be changed everywhere, where we use SelectParamsFromCommandLine()? I'm talking about bitcoind.cpp and bitcoin-cli.cpp, I suggest using the same comment there.

laanwj commented at 8:23 AM on December 20, 2013:

Nah, no need for that. I'll change the comment back.

in src/qt/bitcoin.cpp:None in f7e576f17a outdated

 194 | @@ -195,11 +195,13 @@ int main(int argc, char *argv[])
 195 |      // Register meta types used for QMetaObject::invokeMethod
 196 |      qRegisterMetaType< bool* >();
 197 |  
 198 | +

Diapolo commented at 8:22 AM on December 20, 2013:

Can you remove this new-line, please?

Diapolo commented at 8:30 AM on December 20, 2013: none

weird

IMHO that new layout looks weird, see the buttons?

laanwj commented at 8:36 AM on December 20, 2013: member

Strange... Going to re-do that change manually in the XML instead of using the UI editor. Looks like it changed around a lot of ancillary stuff.

laanwj commented at 8:53 AM on December 20, 2013: member

Ok cleaner change now, thanks for checking.

BitcoinPullTester commented at 9:28 AM on December 20, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/89fc1067718867daeddabcf0a86596b30b74a184 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

Diapolo commented at 9:31 AM on December 20, 2013: none

If you re-work the 2 nits I can ACK this, GUI is fine now.

qt: Treat regtest as testnet

No need to do anything special in the GUI for regtest mode,
but do treat it at testnet not mainnet to prevent confusion.

2ea980a77c

laanwj commented at 10:19 AM on December 20, 2013: member

Done, merging now

laanwj referenced this in commit 326b5bb9d0 on Dec 20, 2013

laanwj merged this on Dec 20, 2013

laanwj closed this on Dec 20, 2013

laanwj deleted the branch on Apr 9, 2014

DrahtBot locked this on Sep 8, 2021