QA: wallet_migration: Test several more weird scenarios #34372

1. 
   luke-jr commented at 5:44 pm on January 21, 2026: member

   Includes the “survive” file test from #34222
2. DrahtBot added the label Tests on Jan 21, 2026
3. 
   DrahtBot commented at 5:44 pm on January 21, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34372.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. DrahtBot added the label CI failed on Jan 21, 2026
5. 
   DrahtBot commented at 5:51 pm on January 21, 2026: contributor

   🚧 At least one of the CI tasks failed. Task lint: https://github.com/bitcoin/bitcoin/actions/runs/21219763361/job/61051058531 LLM reason (✨ experimental): Python lint failure caused by an F-string syntax error in wallet_migration.py.

   Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

   • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

   • An intermittent issue.

   Leave a comment here, if you need help tracking down a confusing failure.

6. QA: wallet_migration: Test that all the failed migration cases also succeed properly 049893d873
7. QA: wallet_migration: Forward port walletdir/survive check

   Extracted-From: 76cdeb7b06232050c7d20ffa1395697cc4e53295 (29.x)

   49aa8db37a
8. QA: wallet_migration: Test survival of a file in the wallet-owned directory itself db22b2d450
9. QA: wallet_migration: Check that reload failure does not leave behind a SQLite journal file 6479ee5e8c
10. QA: wallet_migration: Test ".", "./", "..", and "../subdir" d653409906
11. QA: wallet_migration: Test migration of wallets without a dedicated directory aff522c57c
12. QA: wallet_migration: Test migration of bare "wallet.dat" 7079ec7c94
13. QA: wallet_migration: Abstract named wallet cleanup 2ee335cff2
14. DrahtBot removed the label CI failed on Jan 21, 2026
15. luke-jr force-pushed on Jan 21, 2026
16. QA: wallet_migration: Test various other relative paths 506a5a0ff3
17. DrahtBot added the label CI failed on Jan 21, 2026
18. DrahtBot removed the label CI failed on Jan 21, 2026

Contributors
luke-jr DrahtBot achow101

Labels
Tests