refactor: Remove remaining std::bind, check via clang-tidy #34373

1. 
   maflcko commented at 7:14 pm on January 21, 2026: member

   std::bind has many issues:

   • It is verbose in a meaningless way
   • Overriden args are silently accepted and dropped at runtime without a compile error. Same for accidental duplicates.

   One could use std::bind_front similar to commit fa267551c4eaef577db92e248c4b6d31d0c8bc77. Though, I think the remaining cases are better off with lambdas.

   So do that here, and enable the modernize-avoid-bind clang-tidy rule to avoid std::bind bugs in the future.

2. DrahtBot added the label Refactoring on Jan 21, 2026
3. 
   DrahtBot commented at 7:14 pm on January 21, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34373.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fjahr, purpleKarrot
   Concept ACK	hebasto

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #34276 (Remove empty caption from user interface (noui, gui) by maflcko)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   hebasto commented at 7:16 pm on January 21, 2026: member

   Concept ACK.
5. 
   fjahr commented at 10:16 pm on January 21, 2026: contributor

   Concept ACK
6. refactor: Remove remaining std::bind, check via clang-tidy fad042235b
7. maflcko force-pushed on Jan 28, 2026
8. 
   fjahr commented at 4:56 pm on January 28, 2026: contributor

   Code review ACK fad042235bd6054d99d3f5a07529276b0138b484
9. DrahtBot requested review from hebasto on Jan 28, 2026
10. 
    purpleKarrot commented at 7:02 am on January 29, 2026: contributor

    Code review ACK fad042235bd6054d99d3f5a07529276b0138b484 @maflcko, the signature shows as invalid on GitHub. Maybe you should update your settings or push the commit again with another signature.
11. 
    maflcko commented at 8:14 am on January 29, 2026: member

    @maflcko, the signature shows as invalid on GitHub. Maybe you should update your settings or push the commit again with another signature.

    GitHub has already checked my auth token for the push event, so if you’d trust Microsoft to check my signature, you could as well just trust it to have checked my auth token on the commit push event.

    In any case, the signature is just for myself, and I don’t really want to put the public key and my email into my GitHub settings.

12. fanquake merged this on Jan 29, 2026
13. fanquake closed this on Jan 29, 2026

    ---

14. maflcko deleted the branch on Jan 29, 2026

Contributors
maflcko DrahtBot hebasto fjahr purpleKarrot

Review Requested
hebasto

Labels
Refactoring