qt: Make sure overviewpage button is pressed at startup #3438

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_12_qt_overviewpage_initial changing 1 files +3 −0
  1. laanwj commented at 8:49 AM on December 18, 2013: member

    Due to walletframe changes, the overview page button is no longer automatically selected at startup even though the overview page is shown.

  2. BitcoinPullTester commented at 9:17 AM on December 18, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f8c06169b6927f3811e59e5b4705487df4ce9b5c for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  3. qt: Make sure overviewpage button is pressed at startup
    Due to walletframe changes, the overview page button is no longer
automatically selected at startup even though the overview page is shown.
    d2b6de031f
  4. in src/qt/bitcoingui.cpp:None in f8c06169b6 outdated 
     214 | @@ -215,13 +215,9 @@ void BitcoinGUI::createActions(bool fIsTestnet)
 215 |      historyAction->setShortcut(QKeySequence(Qt::ALT + Qt::Key_4));
 216 |      tabGroup->addAction(historyAction);
 217 |  
 218 | -    connect(overviewAction, SIGNAL(triggered()), this, SLOT(showNormalIfMinimized()));
    Diapolo commented at 12:40 PM on December 18, 2013:

    AFAIK these were needed, if we set setChecked() for any of these from external modules? Did you verify that e.g. using the context/try menu brings the window to front still?

    laanwj commented at 12:43 PM on December 18, 2013:

    Hmm, you're right, sendcoins/receivecoins actions are also in the tray menu.

    Diapolo commented at 8:04 AM on December 20, 2013:

    IMHO it's better to leave these connected or at least add a comment, that when used via tray or other methods, one needs to ensure that showNormalIfMinimized() needs to be called.

    laanwj commented at 8:11 AM on December 20, 2013:

    Yes, I'll remove this from the pull and add a comment.

  5. laanwj referenced this in commit cc661b4d7f on Dec 20, 2013
  6. laanwj merged this on Dec 20, 2013
  7. laanwj closed this on Dec 20, 2013
  8. laanwj deleted the branch on Apr 9, 2014
  9. DrahtBot locked this on Sep 8, 2021
Contributors
laanwjBitcoinPullTesterDiapolo
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:16 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me