test: Add test runner option –ignore-self-check-warnings #34392

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2601-test-skip-warnings changing 1 files +4 −3
  1. maflcko commented at 1:43 pm on January 23, 2026: member

    This should make it easier to run all listed tests, when a dev has an additional local test, but does not want to add it to the test runner list.

    Can be tested via:

    0$ touch ./test/functional/a.py
    1$ ./bld-cmake/test/functional/test_runner.py wallet_disable
    2
    3(It should print an error message and the error message has instructions how to skip it)
    
  2. test: Add test runner option --ignore-self-check-warnings facc35a82a
  3. DrahtBot added the label Tests on Jan 23, 2026
  4. DrahtBot commented at 1:43 pm on January 23, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34392.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK b-l-u-e

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  5. b-l-u-e commented at 6:42 am on January 25, 2026: contributor

    ACK facc35a

    i tested with --ignore-self-check-warnings

    before test exists early

    0
    1Temporary test directory at /tmp/test_runner__🏃_20260125_092010
    2WARNING! The following scripts are not being run: ['a.py']. Check the test lists in test_runner.py.
    

    after

     0./build/test/functional/test_runner.py wallet_disable --ignore-self-check-warnings
     1Temporary test directory at /tmp/test_runner_₿_🏃_20260125_092409
     2WARNING! The following scripts are not being run: ['a.py']. Check the test lists in test_runner.py, or use --ignore-self-check-warnings to ignore the error.
     3Remaining jobs: [wallet_disable.py]
     41/1 - wallet_disable.py passed, Duration: 0 s
     5
     6TEST              | STATUS    | DURATION
     7
     8wallet_disable.py | ✓ Passed  | 0 s
     9
    10ALL               | ✓ Passed  | 0 s (accumulated) 
    11Runtime: 0 s
    
  6. maflcko marked this as a draft on Jan 26, 2026
  7. maflcko commented at 8:41 am on January 26, 2026: member
    Put into draft for now. I maintain my point (https://github.com/bitcoin/bitcoin/pull/34279#issuecomment-3790415028) that it should be trivial and beneficial to just add the test to the list. It is a one-line change and a call to git commit. It shouldn’t take more than a few seconds and only comes with upsides?
  8. b-l-u-e commented at 11:21 am on January 26, 2026: contributor

    Put into draft for now. I maintain my point (#34279 (comment)) that it should be trivial and beneficial to just add the test to the list. It is a one-line change and a call to git commit. It shouldn’t take more than a few seconds and only comes with upsides?

    i feel like this helps devs who keep temporary local tests in their worktree and still be able to run the full suite withot having to edit test_runner.py or delete their working local files since default fail behavior remains and ci unchanged

  9. maflcko marked this as ready for review on Jan 26, 2026
  10. maflcko commented at 1:57 pm on January 26, 2026: member

    i feel like this helps devs who keep temporary local tests

    Fair enough. It helps for temporary tests that are meant to be thrown away soon. However, for any test meant to stay around longer than a month, properly integrating it in the list and into a git commit (and local git history) just seems better to me.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-27 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me