test: assert shift-by-zero identity for arith_uint256 #34415

pull AnmolM-777 wants to merge 1 commits into bitcoin:master from AnmolM-777:test/uint256-shift-zero-identity changing 1 files +8 −0
  1. AnmolM-777 commented at 8:38 pm on January 26, 2026: none

    This adds explicit unit test assertions that left- and right-shifting arith_uint256 values by zero bits is identity-preserving.

    While implicitly covered by existing loops, making this invariant explicit improves clarity and guards against future regressions.

  2. test: assert shift-by-zero identity for arith_uint256 a007aa6588
  3. DrahtBot added the label Tests on Jan 26, 2026
  4. DrahtBot commented at 8:38 pm on January 26, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34415.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept NACK l0rinc

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  5. l0rinc commented at 8:44 pm on January 26, 2026: contributor
    NACK, this is just noise
  6. AnmolM-777 commented at 8:56 pm on January 26, 2026: none
    Thanks for taking a look! I understand the concern about redundancy and agree that keeping the test suite focused is important. I’m happy to close this PR and will keep this feedback in mind for future contributions.
  7. AnmolM-777 closed this on Jan 26, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-27 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me