log: Print warning about privacy-sensitive log info unconditionally #34417

1. 
   maflcko commented at 12:19 pm on January 27, 2026: member

   There is a warning about logs containing privacy-sensitive information. However, it is only printed when at least one debug log category is enabled.

   This is confusing, because:

   • Setting (let’s say) -debug=reindex enables this warning, but it is hard to see what sensitive logs could be contained in reindex debug logs.
   • Dropping -debug=reindex again disabled this warning, but the wallet continues to log txids (and other sensitive stuff) at info level.

   So instead of implying the wrong thing, it would be better to remove this log line (because it should be common sense), or log it unconditionally.

2. log: Print warning about privacy-sensitive log info unconditionally

   Also, fix whitespace in this function, while touching it. Can be
   reviewed via the git option
   --ignore-all-space

   fa9c92d7b6
3. DrahtBot added the label Utils/log/libs on Jan 27, 2026
4. 
   DrahtBot commented at 12:19 pm on January 27, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34417.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sedited, l0rinc

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

5. sedited approved
6. 
   sedited commented at 12:31 pm on January 27, 2026: contributor

   ACK fa9c92d7b6394194696e014e48346a8b8562e16a

   Heh, was about to pop a similar change from my stash.

7. 
   l0rinc commented at 12:51 pm on January 27, 2026: contributor

   ACK fa9c92d7b6394194696e014e48346a8b8562e16a

   While I think that info logs are usually meant to contain less sensitive information (and debug logs are inherently more private), I also don’t mind if others think we should let the user decide, as long as we inform them at all.

8. sedited merged this on Jan 28, 2026
9. sedited closed this on Jan 28, 2026

   ---

10. maflcko deleted the branch on Jan 28, 2026

Contributors
maflcko DrahtBot sedited l0rinc

Labels
Utils/log/libs