inline_check_non_fatal
#34426
G_ABORT_ON_FAILED_ASSUME is true, inline_check_non_fatal called assertion_fail() and then had a throw NonFatalCheckError that was never reachable, because assertion_fail() either aborts or throws and never returns.
Refactored inline_check_non_fatal to use if constexpr (G_ABORT_ON_FAILED_ASSUME) { assertion_fail(...) } else { throw NonFatalCheckError(...) } branch, removing the unreachable throw
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34426.
See the guideline for information on the review process. A summary of reviews will appear here.
Thank you for your contribution. While this stylistic change can make sense on its own, it comes at a cost and risk for the project as a whole. The weak motivation for the change does not justify the burden that it places on the project. A burden could be any of the following:
Generally, if the style is not mentioned nor enforced by the developer notes, we leave it up to the original author to pick whatever fits them best personally and then leave it that way until the line is touched for other reasons.
If you wish to contribute in the future, please focus on creating high-quality, original content that demonstrates a clear understanding of the project’s requirements and goals. Also, see the contributing guidelines.
Leave a comment below, if you have any questions.