ci: mount git directory as writable in linter #34430

1. 
   willcl-ark commented at 1:45 pm on January 28, 2026: member

   On merges to master we set LINT_CI_SANITY_CHECK_COMMIT_SIG (when “GITHUB_REPOSITORY == bitcoin/bitcoin”) which runs verify-commits.py.

   This requires write access to the .git directory. Make the mounted .git directory writable.

   This is currently not run on PR branches or locally which caused a miss during review.

   Ideally we can have the same checks running in PRs as on merges to master to avoid future discrepancies like this.

2. ci: mount .git dir rw

   On merges to master we set LINT_CI_SANITY_CHECK_COMMIT_SIG (when
   "GITHUB_REPOSITORY == bitcoin/bitcoin") which runs verify-commits.py.
   
   This requires write access to the .git directory.
   Make the mounted .git directory writable.
   
   This is currently not run on PR branches or locally which caused a miss
   during review.

   c8abac9941
3. DrahtBot added the label Tests on Jan 28, 2026
4. 
   DrahtBot commented at 1:45 pm on January 28, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34430.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	l0rinc, maflcko

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

5. in ci/lint.py:34 in c8abac9941

   30@@ -31,7 +31,7 @@ def get_worktree_mounts(repo_root):
   31     main_gitdir = gitdir.parent.parent
   32     return [
   33         f"--volume={gitdir}:{gitdir}",
   34-        f"--volume={main_gitdir}:{main_gitdir}:ro",
   35+        f"--volume={main_gitdir}:{main_gitdir}",
   

   ---

   ---

   

   l0rinc commented at 2:03 pm on January 28, 2026:

   seems like a partial fix to #34391 (review)

   ---

   

   willcl-ark commented at 2:14 pm on January 28, 2026:

   Correct. Ideally we’d run the same codepaths on PRs and merges. But in the meatime this will stop CI failing.
6. l0rinc approved
7. 
   l0rinc commented at 2:04 pm on January 28, 2026: contributor

   untested code review ACK c8abac994122b67de8145579489576db5df2b3d3

   We need to fix the builds, in a follow-up we should make sure these are caught before merge.

8. willcl-ark marked this as a draft on Jan 28, 2026
9. 
   maflcko commented at 2:10 pm on January 28, 2026: member

   lgtm ACK c8abac994122b67de8145579489576db5df2b3d3
10. willcl-ark marked this as ready for review on Jan 28, 2026
11. fanquake merged this on Jan 28, 2026
12. fanquake closed this on Jan 28, 2026

    ---

13. 
    maflcko commented at 2:17 pm on January 28, 2026: member

    You may want to reset your name and email, as the lint container corrupted your git dir while testing LINT_CI_SANITY_CHECK_COMMIT_SIG :sweat_smile:

    Maybe LINT_CI_SANITY_CHECK_COMMIT_SIG should be named DANGER_LINT_CI_SANITY_CHECK_COMMIT_SIG.

14. 
    willcl-ark commented at 2:19 pm on January 28, 2026: member

    ha thanks. and this is precisely why this is safest as :ro!

Contributors
willcl-ark DrahtBot l0rinc maflcko

Labels
Tests