script: remove unused SCRIPT_ERR_LAST #34433

pull darosior wants to merge 1 commits into bitcoin:master from darosior:2601_remove_unused_errlast changing 1 files +0 −2
  1. darosior commented at 8:10 pm on January 28, 2026: member

    It was introduced in ab9edbd6b6eb3efbca11f16fa467c3c0ef905708 and never used since. It seems it might have been intended to be exposed as part of a public library interface, which has since been superseded.

    The only call site uses SCRIPT_ERR_ERROR_COUNT directly.

  2. script: remove unused SCRIPT_ERR_LAST
    It was introduced in ab9edbd6b6eb3efbca11f16fa467c3c0ef905708 and never
    used since. It seems it might have been intended to be exposed as part
    of a public library interface, which has since been superseded.
    
    The only call site uses SCRIPT_ERR_ERROR_COUNT directly.
    51abf7d15b
  3. DrahtBot added the label Consensus on Jan 28, 2026
  4. DrahtBot commented at 8:10 pm on January 28, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK sedited, theStack, billymcbip

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  5. sedited approved
  6. sedited commented at 1:12 pm on January 30, 2026: contributor

    ACK 51abf7d15b1da5b74d58a381ced662dc0f70b4b0

    I’m planning on finally exposing these codes, but when that time comes and we still need it, we can easily just put it back again.

  7. theStack approved
  8. theStack commented at 9:56 pm on January 30, 2026: contributor
    ACK 51abf7d15b1da5b74d58a381ced662dc0f70b4b0
  9. billymcbip commented at 12:15 pm on February 1, 2026: contributor
    tACK 51abf7d15b1da5b74d58a381ced662dc0f70b4b0
  10. sedited merged this on Feb 2, 2026
  11. sedited closed this on Feb 2, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-02-15 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me