miniscript: correct and_v() properties #34434

1. 
   darosior commented at 8:31 pm on January 28, 2026: member

   and_v() must never be ’d’. This is not a bug fix since this was unreachable in valid Miniscripts: the first sub of an and_v() must be of type V, which conflicts with (i.e. never has) property ’d'.
2. miniscript: correct and_v() properties

   and_v() must never be 'd'. This is not a bug fix since this was
   unreachable in valid Miniscripts: the first sub of an and_v() must be of
   type V, which conflicts with (i.e. never has) property 'd'.

   4fab35cf88
3. DrahtBot added the label Descriptors on Jan 28, 2026
4. 
   DrahtBot commented at 8:31 pm on January 28, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sipa, achow101

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

5. 
   sipa commented at 8:48 pm on January 28, 2026: member

   Code Review ACK 4fab35cf88c048d2784fe6d71d3f83cc4e420879. The specification says and_v never has the "d" property, while the code seems to give it the "d" property if both sub-fragments have "d" as well. This has no observable effect, because any valid miniscript won’t have "d" in the left sub-fragment.

   Let’s still wait for CI and run some extra fuzzing cycles…

6. 
   sipa commented at 6:10 pm on January 29, 2026: member

   ACK 4fab35cf88c048d2784fe6d71d3f83cc4e420879. Fuzzed for 2 months worth of CPU time.
7. 
   achow101 commented at 9:40 pm on January 29, 2026: member

   ACK 4fab35cf88c048d2784fe6d71d3f83cc4e420879
8. fanquake merged this on Jan 30, 2026
9. fanquake closed this on Jan 30, 2026

   ---

Contributors
darosior DrahtBot sipa achow101

Labels
Descriptors