ci: Always print low ccache hit rate notice #34453

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2601-ci-log-ccache-hit-rate changing 1 files +3 −5
  1. maflcko commented at 8:37 pm on January 29, 2026: member

    Looks like the hit rate is low, even on test changes such as https://github.com/bitcoin/bitcoin/actions/runs/21476546461/job/61867393974#step:10:3349

    to make it easier to debug, unconditionally print the low hit rate notice

  2. ci: Always print low ccache hit rate notice fad2876ec3
  3. DrahtBot added the label Tests on Jan 29, 2026
  4. DrahtBot commented at 8:37 pm on January 29, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK l0rinc, sedited

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

    LLM Linter (✨ experimental)

    Possible typos and grammar issues:

    • hitrate -> hit rate [Two words; “hitrate” is nonstandard and may reduce readability in the title field]
    • Ccache -> ccache [Project/tool name is typically lowercase “ccache”; capitalizing the first letter is a typo that can confuse readers]

    2026-01-29 20:37:38

  5. in ci/test/03_test_script.sh:151 in fad2876ec3
    147@@ -148,11 +148,9 @@ cmake --build "${BASE_BUILD_DIR}" "$MAKEJOBS" --target $GOAL || (
    148 )
    149 
    150 bash -c "${PRINT_CCACHE_STATISTICS}"
    151-if [ "$CI" = "true" ]; then
    152-  hit_rate=$(ccache -s | grep "Hits:" | head -1 | sed 's/.*(\(.*\)%).*/\1/')
    153-  if [ "${hit_rate%.*}" -lt 75 ]; then
    154-      echo "::notice title=low ccache hitrate::Ccache hit-rate in $CONTAINER_NAME was $hit_rate%"
    155-  fi
    156+hit_rate=$(ccache --show-stats | grep "Hits:" | head -1 | sed 's/.*(\(.*\)%).*/\1/')
    


    l0rinc commented at 8:59 pm on January 29, 2026:

    Note: -s is indeed equivalent to --show-stats:

    -s, --show-stats          show summary of configuration and statistics
                              counters in human-readable format (use
                              -v/--verbose once or twice for more details)
    
  6. l0rinc approved
  7. l0rinc commented at 9:01 pm on January 29, 2026: contributor

    ACK fad2876ec330dbb833905d3b2ee5753abc3bc3af

    The CI restricting condition was removed & added the long form of -s to document the code better

  8. sedited approved
  9. sedited commented at 8:09 am on January 30, 2026: contributor
    ACK fad2876ec330dbb833905d3b2ee5753abc3bc3af
  10. sedited merged this on Jan 30, 2026
  11. sedited closed this on Jan 30, 2026

  12. maflcko deleted the branch on Jan 30, 2026
  13. hebasto commented at 11:23 am on January 30, 2026: member
    Post-merge ACK fad2876ec330dbb833905d3b2ee5753abc3bc3af.
  14. fanquake referenced this in commit 7317a0ba1f on Jan 30, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-02-02 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me