Allow `-noserver` with bitcoind #3449

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_12_bitcoind_allow_noserver changing 5 files +11 −17

laanwj commented at 10:50 AM on December 20, 2013: member
Allow running bitcoind without RPC server. Removes a pointless limitation as daemon can still be stopped cleanly by sending it SIGINT/SIGTERM.
- Default to -server mode (of course) for bitcoind with SoftSetBoolArg
- Remove fForceServer argument from AppInit2
- Move fDaemon to a static variable in bitcoind

Allow `-noserver` with bitcoind

Allow running bitcoind without server.

- Default to -server mode (of course) for bitcoind with SoftSetBoolArg
- Remove fForceServer argument from AppInit2
- Move fDaemon to a static variable in bitcoind

8b9adca446

BitcoinPullTester commented at 4:09 PM on December 20, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/8b9adca4461d0cb6bdfca7b74228d430b9b9d116 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
jgarzik commented at 4:18 PM on December 20, 2013: contributor

Umm... why? RPC is the control plane for bitcoind.
laanwj commented at 4:26 PM on December 20, 2013: member

I see no reason for disallowing it.

In any case, it simplifies the code as there is no more special handling needed for the non-GUI / daemon case in AppInit2.
sipa commented at 4:38 PM on December 20, 2013: member

It's also a step towards having it modularized away.
sipa commented at 9:37 PM on December 20, 2013: member

ACK
laanwj referenced this in commit 549e69a558 on Jan 8, 2014
laanwj merged this on Jan 8, 2014
laanwj closed this on Jan 8, 2014
laanwj deleted the branch on Apr 9, 2014
DrahtBot locked this on Sep 8, 2021

Contributors