extend std::exception logging in txdb.cpp #3453

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:txdb changing 1 files +6 −6

Diapolo commented at 5:59 PM on December 20, 2013: none

No description provided.
extend std::exception logging in txdb.cpp 96e5f61d6c
BitcoinPullTester commented at 6:42 PM on December 20, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/96e5f61d6c53299d1d7d7428a943c4db2ecf73c9 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 8:28 PM on December 20, 2013: member

ACK
in src/txdb.cpp:None in 96e5f61d6c
```
  25 | @@ -26,8 +26,8 @@ void static BatchWriteHashBestChain(CLevelDBBatch &batch, const uint256 &hash) {
  26 |  CCoinsViewDB::CCoinsViewDB(size_t nCacheSize, bool fMemory, bool fWipe) : db(GetDataDir() / "chainstate", nCacheSize, fMemory, fWipe) {
  27 |  }
  28 |  
  29 | -bool CCoinsViewDB::GetCoins(const uint256 &txid, CCoins &coins) { 
  30 | -    return db.Read(make_pair('c', txid), coins); 
  31 | +bool CCoinsViewDB::GetCoins(const uint256 &txid, CCoins &coins) {
  32 | +    return db.Read(make_pair('c', txid), coins);
```
laanwj commented at 9:17 AM on December 21, 2013:

I've read over these lines about four times and cannot discover what you changed here. Can you please try to remove them from the diff?
sipa commented at 10:59 AM on December 21, 2013:

Two spaces at the end of the lines. On Dec 21, 2013 10:17 AM, "Wladimir J. van der Laan" < notifications@github.com> wrote:

In src/txdb.cpp:

@@ -26,8 +26,8 @@ void static BatchWriteHashBestChain(CLevelDBBatch &batch, const uint256 &hash) { CCoinsViewDB::CCoinsViewDB(size_t nCacheSize, bool fMemory, bool fWipe) : db(GetDataDir() / "chainstate", nCacheSize, fMemory, fWipe) { }

-bool CCoinsViewDB::GetCoins(const uint256 &txid, CCoins &coins) {

return db.Read(make_pair('c', txid), coins); +bool CCoinsViewDB::GetCoins(const uint256 &txid, CCoins &coins) {

return db.Read(make_pair('c', txid), coins);

I've read over these lines about four times and cannot discover what you changed here. Can you please try to remove them from the diff?

— Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/pull/3453/files#r8516950 .
Diapolo commented at 9:26 AM on December 22, 2013:

Sipa got it.

laanwj commented at 9:34 AM on December 22, 2013:

I see now too. Usually github highlights the last space in this case. I wish that github would develop an ignore-spaces mode.
laanwj commented at 9:24 AM on December 21, 2013: member

ACK on the actual code changes
laanwj referenced this in commit 6e7792003b on Dec 24, 2013
laanwj merged this on Dec 24, 2013
laanwj closed this on Dec 24, 2013
Diapolo deleted the branch on Dec 24, 2013
DrahtBot locked this on Sep 8, 2021

Contributors