Confirmed is always true in export file #3455

When using the export function in the transactions tab, the Confirmed status is always set to "true", even when the real status is "unconfirmed"

Example: In transaction details you see: Status: 0/unconfirmed Date: 12/22/13 01:25 To: 15FJt8Upr2AADDQor1uCt8FKUEVxQTNgfp Debit: -0.062 BTC Transaction fee: -0.0005 BTC Net amount: -0.0625 BTC Transaction ID: 8ef37cd1d9a31a95fe9f0629fc83a16618b19c7ae38d7dde1ccd492b5b73a3b3

And in the csv file you see: "Confirmed","Date","Type","Label","Address","Amount","ID" "true","2013-12-22T01:25:53","Sent to","","15FJt8Upr2AADDQor1uCt8FKUEVxQTNgfp","-0.0625","8ef37cd1d9a31a95fe9f0629fc83a16618b19c7ae38d7dde1ccd492b5b73a3b3-000"

Good luck with this issue!

I could not reproduce this in Linux with Bitcoin v0.8.5.0-gef14a26-beta. Unconfirmed transactions are outputted correctly as "false".

I think the confusion here is that what the "confirmed" column shows is really "does this transaction count toward confirmed balance".

It contains ConfirmedRole for the record, which is tx.IsTrusted() && !(wtx.GetBlocksToMaturity() > 0). What IsTrusted does check if the output of the transaction will be spent. This certainly applies to confirmed transactions, but also to, say, unconfirmed transactions that you sent yourself.

Something more concrete like "number of confirms" would probably be more useful for an export format than this internal flag.

I cannot reproduce this bug both on master and on 0.17.0 (even with "Payment to yourself").

This one should be fixed. See #14988 (comment)