test: Fix intermittent issues in feature_assumevalid.py #34571

1. 
   maflcko commented at 10:29 am on February 12, 2026: member

   The test has many issues:

   • The send_blocks_until_disconnected seems to imply to wait until a disconnect happens. However, in reality it will blindly send all blocks and then return early, when done or when a disconnect happens. This will cause test failures when python is running faster than Bitcoin Core, for example when using sanitizers.
   • The assert_debug_log scopes are bloated, which makes finding the above issue harder. This is, because a test failure will basically print the 1000+ line debug log excerpt twice, with the second instance stripped of useful python test logs. Also, the checks are less precise, if they happen over a larger scope/snippet.

   Fix all issues, by:

   • Removing send_blocks_until_disconnected and just sending the blocks that are needed to get the disconnect and then explicitly waiting for the disconnect.
   • Reduce the scopes of the debug log checks. This can be reviewed with the git options --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space.
2. test: Fix intermittent issues in feature_assumevalid.py fa90d44a22
3. DrahtBot added the label Tests on Feb 12, 2026
4. 
   DrahtBot commented at 10:29 am on February 12, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

5. 
   maflcko commented at 10:36 am on February 12, 2026: member

   Locally, I can reproduce the intermittent issue via while ./bld-cmake/test/functional/feature_assumevalid.py --timeout-factor=4 --valgrind ; do echo >> /tmp/runs_fa ; done.

   An alternative could be:

    0diff --git a/src/validationinterface.cpp b/src/validationinterface.cpp
    1index c7be6abc3a..aacb7b6563 100644
    2--- a/src/validationinterface.cpp
    3+++ b/src/validationinterface.cpp
    4@@ -14,2 +14,3 @@
    5 #include <primitives/transaction.h>
    6+#include <random.h>
    7 #include <util/check.h>
    8@@ -156,2 +157,4 @@ void ValidationSignals::SyncWithValidationInterfaceQueue()
    9 
   10+static FastRandomContext g_rnd{};
   11+
   12 // Use a macro instead of a function for conditional logging to prevent
   13@@ -166,2 +169,3 @@ void ValidationSignals::SyncWithValidationInterfaceQueue()
   14             LOG_EVENT(fmt, local_name, __VA_ARGS__);           \
   15+            if(g_rnd.randrange(2)<1)UninterruptibleSleep(15ms);\
   16             event();                                           \
   

6. fanquake added this to the milestone 31.0 on Feb 12, 2026

Contributors
maflcko DrahtBot

Labels
Tests

Milestone
31.0