test: Set assert_debug_log timeout to 0 #34581

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2602-test-time-0 changing 13 files +44 −35
  1. maflcko commented at 11:54 am on February 13, 2026: member

    The assert_debug_log helper is meant to be a context manager. However, it has a default timeout of 2 seconds, and can act as a silent polling/wait/sync function. This is confusing and brittle, and leads to intermittent bugs such as #34571.

    Fix all issues, by setting the default timeout to zero. Then adjust all call sites to either use this correctly like a context manager, or adjust them explicitly to specify a timeout, to document that this is a polling sync function.

  2. test: Set assert_debug_log timeout to 0 fabaf466b9
  3. DrahtBot added the label Tests on Feb 13, 2026
  4. DrahtBot commented at 11:54 am on February 13, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hodlinator

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #34533 (wallet: resubmit transactions with private broadcast if enabled by vasild)
    • #34359 (test: add test for rebroadcast of transaction received via p2p by mzumsande)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    LLM Linter (✨ experimental)

    Possible typos and grammar issues:

    • resubmit 1 unconfirmed transactions -> resubmit 1 unconfirmed transaction [singular/plural mismatch: “1” should pair with the singular “transaction”]

    2026-02-13 11:54:46

  5. hodlinator approved
  6. hodlinator commented at 8:38 am on February 16, 2026: contributor

    ACK fabaf466b938f0b2da6e25af2eb24f4731fcd358

    Agree it’s more robust to default to 0 timeout and push code blocks towards being sufficient to print the log messages.

    Double-checked that the timeout value is multiplied by timeout_factor internally.

    Ran this 3 times without any skipped tests or failures:

    0./build/test/functional/test_runner.py --loglevel=debug feature_anchors.py feature_config_args.py p2p_compactblocks.py p2p_dns_seeds.py p2p_headers_sync_with_minchainwork.py p2p_initial_headers_sync.py p2p_mutated_blocks.py p2p_sendtxrcncl.py p2p_timeouts.py p2p_v2_transport.py rpc_net.py wallet_resendwallettransactions.py
    

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-02-17 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me