Move IsInitialBlockDownload from main to checkpoints #3460

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_12_move_isinitialblockdl changing 6 files +32 −27

laanwj commented at 1:08 PM on December 24, 2013: member

Low-risk part of #3088
Move IsInitialBlockDownload from main to checkpoints
Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
ea30d7ae9c
BitcoinPullTester commented at 1:56 PM on December 24, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ea30d7ae9c52722bd7d733cfaa4ab55cace8213f for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 8:10 PM on December 25, 2013: member

I don't really like making checkpoints even more dependent on main. Ideally, it should be just some data with accessors, and even more ideally, be removed entirely.
laanwj commented at 9:35 PM on December 25, 2013: member

IMO IsInitialBlockDownload shouldn't be in main either because it is not part of consensus.

Anyhow I thought from discussion in #3088 that this was pretty non-controversial.

Closing...
laanwj closed this on Dec 25, 2013
DrahtBot locked this on Sep 8, 2021

Contributors