wallet, test: improve wallet functional tests #34709

1. 
   rkrux commented at 8:56 am on March 2, 2026: contributor

   Relates to #34354

   While the actual fix of the issue is in another PR, this one improves the affected tests by trying to reduce the chain notifications that need to be processed while simulating erroneous wallet restoration scenarios.

2. 
   DrahtBot commented at 8:56 am on March 2, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, furszy, w0xlt, brunoerg

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

3. test: improve `wallet_assumeutxo` func test

   Reduce the number of blocks that need to be generated before pruning
   the blockchain.
   
   Unload the wallet that was restored in a prior test because it is not
   needed anymore after the test.
   
   Both the above steps should reduce the number of chain notifications
   that need to be processed by the wallet(s) when an erroneous scenario
   of restoring wallet is checked.

   04d9515748
4. test: improve `wallet_backup` test

   Remove the unused functions that were ported many years back.

   5c005363a8
5. rkrux force-pushed on Mar 2, 2026
6. rkrux marked this as ready for review on Mar 2, 2026
7. DrahtBot added the label CI failed on Mar 2, 2026
8. rkrux renamed this:
   wallet, test: improve couple wallet functional tests
   wallet, test: improve wallet functional tests
   on Mar 2, 2026
9. 
   maflcko commented at 10:16 am on March 2, 2026: member

   lgtm ACK 5c005363a880c136cc44ff2456a402e398fcbf44
10. 
    rkrux commented at 11:34 am on March 2, 2026: contributor

    The interface_zmq test failure in CI / TSan (pull_request) should be unrelated, it’s failing on other PRs as well.
11. DrahtBot removed the label CI failed on Mar 2, 2026
12. 
    furszy commented at 1:26 pm on March 2, 2026: member

    ACK 5c005363a880c136cc44ff2456a402e398fcbf44
13. 
    w0xlt commented at 6:57 pm on March 2, 2026: contributor

    ACK 5c005363a880c136cc44ff2456a402e398fcbf44
14. brunoerg approved
15. 
    brunoerg commented at 11:34 pm on March 2, 2026: contributor

    code review ACK 5c005363a880c136cc44ff2456a402e398fcbf44
16. fanquake merged this on Mar 5, 2026
17. fanquake closed this on Mar 5, 2026

    ---

Contributors
rkrux DrahtBot maflcko furszy w0xlt brunoerg