test: replace bare asserts with assertion helpers in rpc_blockchain.py #34738

1. 
   Bortlesboat commented at 2:00 am on March 5, 2026: none

   Replace 6 bare assert statements in test/functional/rpc_blockchain.py with test framework assertion helpers (assert_greater_than, assert_greater_than_or_equal, assert_approx).

   Bare asserts produce unhelpful AssertionError with no context on failure. The test framework helpers print the actual vs expected values, making debugging much easier.

   Changes:

   • assert height >= 144 and height <= 287 → two assert_greater_than_or_equal calls
   • assert size > 6400 / assert size < 64000 → assert_greater_than calls
   • Two assert abs(x - 1) < 0.0001 patterns → assert_approx(x, 1, vspan=0.0001)
   • assert hashes_per_second > 0.003 → assert_greater_than
   • Added assert_approx to the existing import block

   Each replacement preserves the exact same logical condition.

   Part of #23119.

2. test: replace bare asserts with assertion helpers in rpc_blockchain.py

   Replace 6 bare assert statements with test framework assertion helpers
   (assert_greater_than, assert_greater_than_or_equal, assert_approx) to
   produce more informative error messages on failure.
   
   Part of #23119.

   bc769e1a47
3. DrahtBot added the label Tests on Mar 5, 2026
4. 
   DrahtBot commented at 2:01 am on March 5, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

5. 
   maflcko commented at 6:30 am on March 5, 2026: member

   lgtm ACK bc769e1a4771f8e6a6959cf8e7f07698c5b07826
6. Bortlesboat closed this on Mar 6, 2026

   ---

Contributors
Bortlesboat DrahtBot maflcko

Labels
Tests