AddWhitelistPermissionFlags was always being called with an empty ranges (whitelist permissions). This function is called when connecting to a node (ConnectNode), and if the connection is a manual one, it uses the vWhitelistedRangeOutgoing to populate the permissions. However, since we were not setting any whitelist permission on the target, this vector is always empty. This PR improves this target by populating both vWhitelistedRangeIncoming and vWhitelistedRangeOutgoing.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | Crypt-iQ, frankomosh, maflcko |
If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.
78@@ -79,6 +79,18 @@ FUZZ_TARGET(connman, .init = initialize_connman)
79 CConnman::Options options;
80 options.m_msgproc = &net_events;
81 options.nMaxOutboundLimit = max_outbound_limit;
82+
83+ auto consume_whitelist = [&]() {
84+ std::vector<NetWhitelistPermissions> result(fuzzed_data_provider.ConsumeIntegralInRange<size_t>(0, 3));
85+ for (auto& entry : result) {
86+ entry.m_flags = ConsumeWeakEnum(fuzzed_data_provider, ALL_NET_PERMISSION_FLAGS);
Implicit? I think TryParsePermissionFlags never produces it with other flags.
Implicit would be considered as if both -whitebind or -whitelist had not been defined, perhaps we can leave it as is.
lgtm ACK 32debfa1ed8168bca0b6d2f191d2e3e940f6029b
I think it would be useful to include steps to test this. E.g. by showcasing one additional line of coverage that is achieved, where is previously wasn’t.