Improved CustomBuildField for std::optional in IPC/libmultiprocess #34797

pull mangoostaa wants to merge 1 commits into bitcoin:master from mangoostaa:feature/optional-forward changing 1 files +1 −1

mangoostaa commented at 9:17 AM on March 11, 2026: none

The function now uses std::forward<Value>(value) when building the field, so rvalues are forwarded correctly instead of always being treated as lvalues. This resolves the existing FIXME in that code path.

Details Previously, the implementation forced every optional value to be accessed as an lvalue, which meant rvalues were unnecessarily copied. By applying perfect forwarding, the function now preserves the value category and allows moves where appropriate. The FIXME comment was removed since the intended behavior is now implemented
Use std::forward in CustomBuildField for std::optional to allow move semantics, resolves FIXME b59d4dbcfa
DrahtBot commented at 9:17 AM on March 11, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
sedited commented at 9:28 AM on March 11, 2026: contributor

Can you open this against https://github.com/bitcoin-core/libmultiprocess/pulls ? We generally don't accept changes to subtrees in this repository.
sedited closed this on Mar 11, 2026

Contributors