Lost in include dependency loop #348

issue laanwj opened this issue on June 26, 2011
  1. laanwj commented at 10:32 AM on June 26, 2011: member

    So I thought I'd spend my sunday afternoon porting my GUI to the newest bitcoin git version. I got lost in the forest on the first file I tried to compile, though;

    qt/bitcoin.cpp (mine) includes util.h util.h includes uint256.h uint256.h includes serialize.h serialize.h includes wallet.h wallet.h includes bignum.h bignum.h includes utl.h

    That's one epic dependency loop. I see no trivial way to split it up (like adding forward declaration), as there is a lot of inline code in the headers that uses the actual types.

    Of course, I could get my hacksaw and saw off pieces here and there until this until it compiles again. But it might be better to make an actual plan as to how to split up the includes. How is this supposed to work?

  2. laanwj commented at 10:41 AM on June 26, 2011: member

    ok, I fucked up here, it's a mess but not this bad... I had accidentally created a loop myself; closing the issue

  3. laanwj closed this on Jun 26, 2011

  4. sipa referenced this in commit 003bb87153 on Nov 5, 2015
  5. sipa referenced this in commit bfd83199c3 on Nov 11, 2015
  6. sipa referenced this in commit b437ea7ec9 on Nov 12, 2015
  7. sipa referenced this in commit 1d84107924 on Nov 12, 2015
  8. jtimon referenced this in commit 91ee21c024 on Mar 11, 2016
  9. sipa referenced this in commit f41ed612dd on Aug 27, 2016
  10. sipa referenced this in commit 2f342da4b9 on Nov 30, 2016
  11. sipa referenced this in commit 634ad51703 on Dec 2, 2016
  12. rebroad referenced this in commit 40ead34fbe on Dec 7, 2016
  13. deadalnix referenced this in commit 970164dace on Jan 19, 2017
  14. ptschip referenced this in commit 6430d68d6e on Mar 8, 2017
  15. classesjack referenced this in commit 396ffeb247 on Jan 2, 2018
  16. rajarshimaitra referenced this in commit 763ea48fc7 on Aug 5, 2021
  17. DrahtBot locked this on Dec 16, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me