qt: Remove unused method OptionsModel::getTransactionFee #3489

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_01_optionsmodel_remove_unused_method changing 2 files +0 −6

laanwj commented at 2:13 PM on January 6, 2014: member

As it says on the tin.
qt: Remove unused method OptionsModel::getTransactionFee 2a7201570b
Diapolo commented at 2:28 PM on January 6, 2014: none

AFAIK I also don't need it anymore in my options-update-pull, so ACK.
BitcoinPullTester commented at 3:00 PM on January 6, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/2a7201570bd645f2b2b78544498e961bbc9a15a8 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 3:06 PM on January 6, 2014: member

Ok that's good, and somewhat expected as the options dialog shouldn't use direct getters.

I noticed that this method was unused while rebasing #3392. It suppose it became unused after the send confirmation dialog changes.
laanwj referenced this in commit 65515c0d05 on Jan 6, 2014
laanwj merged this on Jan 6, 2014
laanwj closed this on Jan 6, 2014
laanwj deleted the branch on Apr 9, 2014
DrahtBot locked this on Sep 8, 2021

Contributors